Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support case insensitive bidder name in storedbidresponse #3139

Merged
merged 1 commit into from
Sep 26, 2023

Conversation

onkarvhanumante
Copy link
Contributor

@onkarvhanumante onkarvhanumante commented Sep 25, 2023

PR makes changes to support case insensitive bidder names in ext.prebid.storedbidresponse.bidder

As shown below bidder name appnexus is known name to PBS. But APPNEXUS is unknown. Prior to PR changes PBS would have error out with unknown APPNEXUS bidder name messgae. PR has implemented insensitive bidder name comparison in ext.prebid.storedbidresponse.bidder

        "ext": {
          "appnexus": {
            "placementId": 12883451
          },
          "prebid": {
            "storedbidresponse": [
              {
                "bidder": "APPNEXUS",
                "id": "bidResponseId3"
              }
            ]
          }
        }

partially resolves #2400

@onkarvhanumante onkarvhanumante changed the title Support case insensitive bidder name in ext.prebid.storedbidresponse.bidder Support case insensitive bidder name in storedbidresponse Sep 25, 2023
@gargcreation1992 gargcreation1992 merged commit 00bdbef into master Sep 26, 2023
3 checks passed
@bsardo bsardo removed the PBS 2.0 label Sep 26, 2023
@SyntaxNode SyntaxNode deleted the insensitive-bidder-name-stored-resp branch October 2, 2023 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bidder names should be case insensitive
4 participants