Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support case insensitive bidder name in adjustment factors #3126

Closed
wants to merge 6 commits into from
Closed

Support case insensitive bidder name in adjustment factors #3126

wants to merge 6 commits into from

Conversation

onkarvhanumante
Copy link
Contributor

PR makes changes to support case insensitive bidder names in adjustment factors.

As shown below bidder name appnexus is known name to PBS. But APPNEXUS is unknown. Prior to PR changes PBS would have error out with unknown APPNEXUS bidder name messgae. PR has implemented insensitive bidder name comparison in bidadjustmentfactors

    {
       "imp": [
            {
               "ext": {
                   "prebid": {
                      "bidder": {
                          "APPNEXUS": { // sensitive appnexus
                          }
                       }
                    }
               }
            }
        ],
        ext: {
          "prebid": {
              "bidadjustmentfactors": {
                   "APPNEXUS": 1 // sensitive appnexus
               }
           }

gargcreation1992
gargcreation1992 reviewed Sep 25, 2023
View reviewed changes
endpoints/openrtb2/auction.go
bidderName = normalizedCoreBidder.String()
}

if _, isBidder := deps.bidderMap[bidderName]; !isBidder {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add a sample request and response that you have tested for this change?

Copy link
Contributor Author

@onkarvhanumante onkarvhanumante Sep 25, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

testing is covered by json framework tests

gargcreation1992
gargcreation1992 reviewed Sep 25, 2023
View reviewed changes
Copy link
Contributor

@gargcreation1992 gargcreation1992 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

requesting to please test locally if not done already and add request and response that you have tested.

Base automatically changed from PBS-1254-1 to master September 25, 2023 16:53
@gargcreation1992 gargcreation1992 dismissed their stale review September 25, 2023 16:53

The base branch was changed.

@onkarvhanumante
Copy link
Contributor Author

Closing this PR because commit got messed up after base branch PBS-1254-1 was deleted.

New PR - #3140

@onkarvhanumante onkarvhanumante deleted the PBS-1256 branch September 25, 2023 18:47
@bsardo bsardo removed the PBS 2.0 label Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gargcreation1992 gargcreation1992 gargcreation1992 left review comments

Assignees

@gargcreation1992 gargcreation1992

@Sonali-More-Xandr Sonali-More-Xandr

Labels
do not port
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@onkarvhanumante @gargcreation1992 @bsardo @Sonali-More-Xandr