Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Adapter: Edge226 #3105

Merged
merged 5 commits into from
Oct 16, 2023
Merged

New Adapter: Edge226 #3105

merged 5 commits into from
Oct 16, 2023

Conversation

Edge226Ads
Copy link
Contributor

@Edge226Ads Edge226Ads commented Sep 14, 2023 •
edited
Loading

New adapter Edge226
Dev docs pull request: prebid/prebid.github.io#4864

@Edge226Ads Edge226Ads mentioned this pull request Sep 14, 2023
Merged
6 tasks
@github-actions
Copy link

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 46e2e36

edge226

Refer here for heat map coverage report

github.com/prebid/prebid-server/adapters/edge226/edge226.go:29:		Builder			100.0%
github.com/prebid/prebid-server/adapters/edge226/edge226.go:36:		MakeRequests		85.7%
github.com/prebid/prebid-server/adapters/edge226/edge226.go:83:		makeRequest		85.7%
github.com/prebid/prebid-server/adapters/edge226/edge226.go:100:	MakeBids		100.0%
github.com/prebid/prebid-server/adapters/edge226/edge226.go:136:	getMediaTypeForImp	100.0%
total:									(statements)		92.2%

@Edge226Ads Edge226Ads marked this pull request as ready for review September 14, 2023 16:06
@bsardo bsardo changed the title New adapter Edge226 New Adapter: Edge226 Sep 20, 2023
@github-actions
Copy link

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 685814b

edge226

Refer here for heat map coverage report

github.com/prebid/prebid-server/adapters/edge226/edge226.go:29:		Builder			100.0%
github.com/prebid/prebid-server/adapters/edge226/edge226.go:36:		MakeRequests		85.7%
github.com/prebid/prebid-server/adapters/edge226/edge226.go:83:		makeRequest		85.7%
github.com/prebid/prebid-server/adapters/edge226/edge226.go:100:	MakeBids		100.0%
github.com/prebid/prebid-server/adapters/edge226/edge226.go:136:	getMediaTypeForImp	100.0%
total:									(statements)		92.2%

Sonali-More-Xandr
Sonali-More-Xandr reviewed Sep 25, 2023
View reviewed changes
static/bidder-info/edge226.yaml Outdated
- native
userSync:
redirect:
url: "https://ssp.dauup.com/pserver?gdpr={{.GDPR}}&gdpr_consent={{.GDPRConsent}}&us_privacy={{.USPrivacy}}&redir={{.RedirectURL}}"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The redirect url is not working for me
https://ssp.dauup.com/pserver?gdpr=&gdpr_consent=&us_privacy=&redir=https%3A%2F%2Fib.adnxs.com%2Fsetuid%3Fbidder%3Dedge226%26gdpr%3D%26gdpr_consent%3D%26gpp%3D%26gpp_sid%3D%26f%3Db%26uid%3D%5BUID%5D

image

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Edge226Ads The cookie sync url is still failing with 404. Please re-verify.

@github-actions
Copy link

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 0df50db

edge226

Refer here for heat map coverage report

github.com/prebid/prebid-server/adapters/edge226/edge226.go:29:		Builder			100.0%
github.com/prebid/prebid-server/adapters/edge226/edge226.go:36:		MakeRequests		85.7%
github.com/prebid/prebid-server/adapters/edge226/edge226.go:83:		makeRequest		85.7%
github.com/prebid/prebid-server/adapters/edge226/edge226.go:100:	MakeBids		100.0%
github.com/prebid/prebid-server/adapters/edge226/edge226.go:136:	getMediaTypeForImp	100.0%
total:									(statements)		92.2%

gargcreation1992
gargcreation1992 reviewed Sep 29, 2023
View reviewed changes
Copy link
Contributor

@gargcreation1992 gargcreation1992 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few suggestions

@github-actions
Copy link

github-actions bot commented Oct 3, 2023

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 2dde5cd

edge226

Refer here for heat map coverage report

github.com/prebid/prebid-server/adapters/edge226/edge226.go:28:		Builder		100.0%
github.com/prebid/prebid-server/adapters/edge226/edge226.go:35:		MakeRequests	85.7%
github.com/prebid/prebid-server/adapters/edge226/edge226.go:82:		makeRequest	85.7%
github.com/prebid/prebid-server/adapters/edge226/edge226.go:99:		MakeBids	100.0%
github.com/prebid/prebid-server/adapters/edge226/edge226.go:132:	getBidMediaType	83.3%
total:									(statements)	90.0%

@github-actions
Copy link

github-actions bot commented Oct 3, 2023

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, db1335f

edge226

Refer here for heat map coverage report

github.com/prebid/prebid-server/adapters/edge226/edge226.go:28:		Builder		100.0%
github.com/prebid/prebid-server/adapters/edge226/edge226.go:35:		MakeRequests	85.7%
github.com/prebid/prebid-server/adapters/edge226/edge226.go:82:		makeRequest	85.7%
github.com/prebid/prebid-server/adapters/edge226/edge226.go:99:		MakeBids	100.0%
github.com/prebid/prebid-server/adapters/edge226/edge226.go:132:	getBidMediaType	83.3%
total:									(statements)	90.0%

@gargcreation1992
Copy link
Contributor

@Edge226Ads User sync url is not working. Requesting you to please address the comment.

@Edge226Ads
Copy link
Contributor Author

@gargcreation1992 Sync removed 0df50db

@Sonali-More-Xandr Sonali-More-Xandr merged commit 3c7d852 into prebid:master Oct 16, 2023
5 checks passed
@cross-repo-issue-creation cross-repo-issue-creation bot mentioned this pull request Oct 16, 2023
Closed
svamiftah pushed a commit to sovrn/prebid-server that referenced this pull request Nov 21, 2023
@Edge226Ads @svamiftah
New Adapter: Edge226 (prebid#3105)
dd0932c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@Sonali-More-Xandr Sonali-More-Xandr Sonali-More-Xandr approved these changes

@gargcreation1992 gargcreation1992 gargcreation1992 approved these changes

Assignees

@gargcreation1992 gargcreation1992

@Sonali-More-Xandr Sonali-More-Xandr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Edge226Ads @gargcreation1992 @Sonali-More-Xandr