Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v3.0.0 import path major version mismatch #4030

Closed
System-Glitch opened this issue Oct 31, 2024 · 4 comments
Closed

v3.0.0 import path major version mismatch #4030

System-Glitch opened this issue Oct 31, 2024 · 4 comments

Comments

@System-Glitch
Copy link

It is currently impossible to import version v3.0.0 of the package because of mismatch with the import path.

$ go get github.com/prebid/prebid-server/[email protected]
go: github.com/prebid/prebid-server/[email protected]: invalid version: module path includes a major version suffix, so major version must match

The go toolchain enforces the major version number to match with the import path. I suggest the following changes:

go.mod:

- module github.com/prebid/prebid-server/v2
+ module github.com/prebid/prebid-server/v3

Everywhere else:

- github.com/prebid/prebid-server/v2
+ github.com/prebid/prebid-server/v3

You then need to invalidate the current v3.0.0 tag by editing the go.mod:

retract v3.0.0 // Forgot to update major version in import path and module name

Go docs :

@System-Glitch
Copy link
Author

I just noticed this MR that is fixing the issue already.

@SyntaxNode
Copy link
Contributor

We realized this just after cutting the release. v3.0.1 will be released today with the fix. I've added the retract statement to fix the import toolchain.

Impressed you noticed this so quickly. Is this a bot?

@System-Glitch
Copy link
Author

We have a notification for new prebid-server releases. While trying to upgrade this morning I noticed the issue.

@SyntaxNode
Copy link
Contributor

Addressed in v3.1.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

2 participants