Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable targeting prefix #3094

Open
bretg opened this issue Sep 11, 2023 · 3 comments
Open

Configurable targeting prefix #3094

bretg opened this issue Sep 11, 2023 · 3 comments
Labels
enhancement good first issue Issues which are good for new contributors looking to get involved in the project PBS-Go

Comments

@bretg
Copy link
Contributor

bretg commented Sep 11, 2023

We've gotten feedback that some publishers want a different set of ad targeting prefixes than hb_. One example is that they already have line items setup and want to move to a different set. Another example is a 'bake-off' where they want to run their original managed service and a new managed service side-by-side.

It's not currently possible in PBS to define alternate prefixes for targeting output without creating a server-side module.

Here's a proposed way to make this configurable:

  1. allow the request to contain ext.prebid.targeting.prefix: "blah_"
  2. support an account-level configuration for this instead of requiring stored requests to contain ext.prebid.targeting. Suggestion: auction.targeting.prefix

If both request.ext.prebid.targeting.prefix and auction.targeting.prefix config are present, prefer the request value.

If the value of the prefix is longer then settings.targeting.truncate-attr-chars, ignore it and add a warning to ext.warnings.

Yes, this feature could result in unusable targeting if the prefix is too long and settings.targeting.truncate-attr-chars is not raised from the default of 20. User beware.

@simas-b
Copy link

simas-b commented Sep 12, 2023

There is also a closely related enhancement regarding making it possible to opt out of targeting, wanted to mention it for the context: #2030

@bretg
Copy link
Contributor Author

bretg commented Sep 22, 2023

Discussed in committee, split these features into two issues.

@bretg bretg moved this from Triage to Clarify Request in Prebid Server Prioritization Sep 22, 2023
@bretg bretg moved this from Clarify Request to Ready for Dev in Prebid Server Prioritization Sep 26, 2023
@bretg bretg changed the title Targeting enhancements Configurable targeting prefix Sep 26, 2023
@bretg
Copy link
Contributor Author

bretg commented Dec 13, 2023

Done in PBS-Java 2.5

@bretg bretg added the PBS-Go label Dec 13, 2023
@bsardo bsardo added the good first issue Issues which are good for new contributors looking to get involved in the project label Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement good first issue Issues which are good for new contributors looking to get involved in the project PBS-Go
Projects
Status: Ready for Dev
Development

No branches or pull requests

3 participants