LiveIntent UserId module: fix Ajax timeout when calling the collector endpoint #10425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
5 tasks
ChrisHuie
changed the title
|
@ChrisHuie Do you have an idea why the tests are failing. |
|
@3link it is saying the package and package-lock file are out of sync. Maybe try running npm install and see if that syncs the files back up |
|
@ChrisHuie Thank you! Fixed. |
ChrisHuie
approved these changes
Sep 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Prebid has changed the semantics of the Ajax timeout 0. It used to mean "no timeout". In Prebid version 8 it mean "immediate" timeout. This affected the calls to the collector endpoint which had a default timeout of 0. This PR introduces a default non-zero Ajax timeout for the collector endpoint, makes that timeout configurable and also makes the default Ajax timeout for the resolution endpoint more explicit (not hidden in the live-connect dependency).
Other information