Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lm_Kiviads Bid Adapter : initial adapter release #10415

Merged
merged 8 commits into from
Oct 3, 2023

Conversation

KiviAds
Copy link
Contributor

@KiviAds KiviAds commented Aug 30, 2023

Type of change

  • New bidder adapter

Description of change

New prebid adapter to connect to kiviads.com demand source

  • contact email of the adapter’s maintainer: [email protected]
  • test parameters for validating bids:
[
    {
        code: 'test-banner',
        mediaTypes: {
            banner: {
                sizes: [[300, 250]],
            }
        },
        bids: [
            {
                bidder: 'lm_kiviads',
                params: {
                    env: 'lm_kiviads',
                    pid: '40',
                    ext: {}
                }
            }
        ]
    },
    {
        code: 'test-video',
        sizes: [ [ 640, 480 ] ],
        mediaTypes: {
            video: {
                playerSize: [640, 480],
                context: 'instream',
                skipppable: true
            }
        },
        bids: [{
            bidder: 'lm_kiviads',
            params: {
                env: 'lm_kiviads',
                pid: '40',
                ext: {}
            }
        }]
    }
];

Other information

Docs PR: prebid/prebid.github.io#4829

@bretg
Copy link
Collaborator

bretg commented Sep 1, 2023

@KiviAds - would it be possible to change your placement param to pid to make it match your server-side parameter?

@KiviAds
Copy link
Contributor Author

KiviAds commented Sep 4, 2023

changed placement -> pid according to server-side parameters

@ChrisHuie ChrisHuie changed the title Lm kiviads Lm_Kiviads Bid Adapter : initial adapter release Sep 5, 2023
@ChrisHuie ChrisHuie requested a review from lksharma September 5, 2023 19:35
@KiviAds KiviAds closed this Sep 6, 2023
@KiviAds KiviAds reopened this Sep 6, 2023
@KiviAds
Copy link
Contributor Author

KiviAds commented Sep 8, 2023

@lksharma Hi, could you please check this pr? Thank you

lksharma
lksharma previously approved these changes Sep 27, 2023
Copy link
Collaborator

@lksharma lksharma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@KiviAds please see my comment below on the bidder alias.

@lksharma lksharma dismissed their stale review September 27, 2023 15:46

pending resolution on alias unique name


export const spec = {
code: BIDDER_CODE,
aliases: ['kivi', 'kiviads'],
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aliases should be unique for the first 6 characters. There is already another another adapter with a bidder code named: kiviads

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lksharma, thanks for the information. The mistake has been fixed

@KiviAds KiviAds requested a review from lksharma October 3, 2023 08:32
Copy link
Collaborator

@lksharma lksharma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lksharma lksharma merged commit a2fc26a into prebid:master Oct 3, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants