-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Debug logging not displaying the prebid version since 2.0 #3997
Comments
Did you reference the correct pull-request? I don't see the revert in 3776. |
whoops, thanks! updated in description |
why was it reverted @jsnellbaker ? there's not much of a description in the pull-request. |
I think there were build issues at the time (I think they were in circleci) that resulted from this line of code: I was trying to recreate/retest the changes yesterday, but I had to change gears after something came up. I can take another look if you want. |
yeah that'd be great. I don't see why that change should cause any issues and I don't think it would have merged if it was causing CI issues. but if it is causing issues, it'd be nice to know what they are so I can fix them. |
@snapwich I setup the changes again in this branch However when digging more into my past messages, I found the cause for the revert. When running Below is a copy of one of the messages:
Would you be able to help take a look? |
I'll dig in. We're definitely experiencing the same thing as this: webpack-contrib/istanbul-instrumenter-loader#83 Although that has no fix. But at least we know what tool the issue is coming from. |
should be fixed by #4007 , let us know if that is not the case. |
Type of issue
Bug
Description
After version 2.0 the prebid version is not being logged to the console
Steps to reproduce
Import the project as suggested in the example available in http://prebid.org/dev-docs/examples/basic-example.html
and notice that e.g. "INFO: Prebid.js v2.18.0 loaded" is not showing.
Other information
dupe of closed bug #3700
This issue was fixed in #3714 but then the fix was reverted in #3736
my opinion: setConfig() calls should not wait until pbjs.processQueue() is called
The text was updated successfully, but these errors were encountered: