Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hello world link in pr welcome text broken #12011

Closed
patmmccann opened this issue Jul 22, 2024 · 0 comments · Fixed by #12019
Closed

Hello world link in pr welcome text broken #12011

patmmccann opened this issue Jul 22, 2024 · 0 comments · Fixed by #12019
Assignees
Labels

Comments

@patmmccann
Copy link
Collaborator

          > Hi @tongwu-sh ? It seems your adapter needs a tiny bit of additional maintenance: please move the common get connection logic in your adapter and prisma into a file in /libraries

It seems you also have a bug in your battr support; I think it is on imp.banner instead of imp

Please also document this endpoint change on the docs repo

Thanks for the comments; I've made the updates. How should we test this part? Be sure to test the integration with your ad server using the [Hello World](https://github.com/integrationExamples/gpt/hello_world.html) sample page. It seems the URL is not working.

Originally posted by @tongwu-sh in #12004 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging a pull request may close this issue.

1 participant