Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

timeoutBuffer config redundat? #11959

Closed
bozghiyy opened this issue Jul 11, 2024 · 1 comment · Fixed by #11960
Closed

timeoutBuffer config redundat? #11959

bozghiyy opened this issue Jul 11, 2024 · 1 comment · Fixed by #11960

Comments

@bozghiyy
Copy link
Contributor

Type of issue

Question. Might be a better one for documentation, but wanted to ask first.

Description

I was looking through config options and seems that timeoutBuffer is not used in the code anymore.
I can only see it in config.js: https://github.com/search?q=repo%3Aprebid%2FPrebid.js%20timeoutBuffer&type=code so this config is redundant from what I am seeing.
I see documentation still exists: https://docs.prebid.org/dev-docs/publisher-api-reference/setConfig.html#set-timeout-buffer

Is this doing anything?
If not, isn't better to remove if from config.js and documentation?

Other information

I cannot find a PR when the use of timeoutBuffer was removed from auction.

@dgirardi
Copy link
Collaborator

It was referenced until #10379, but as far as I can tell it already had no effect then. Going as far back as 1.0, bids were timed out after the auction timeout, and after the auction timeout + timeoutBuffer, which is always too late if timeoutBuffer is positive.

If not, isn't better to remove if from config.js and documentation?

Agreed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging a pull request may close this issue.

2 participants