-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Targeting: set pps to GAM display #10997
Comments
Some quirks: setAdServerFPD seems preferred so we don't introduce a dependency on GPT and break parallel loading of gpt and auctions. For us, FPD is an auction property, should we use the latest auction? Should we take an ad unit as an argument or an auction id? Could we offer all three depending on the arguments? () -> use latest, (auctionId =) -> use latest on the auctionid, (adunitcode = ), look up latest auction on this adunit. Let's make a module for it and call it the GAM FPD Sync Module. |
It's not clear how this should be done:
|
when setTargeting is called for mulitple ad units, if they have conflicting site.content.data or user.data, abort setting pps (pub provided segments).
My understanding is they are independent. gpt.js is not used for the video call |
Type of issue
Feature
Description
in #10977 (closing #10687) we set PPS Json for video for IAB segtax 4 (users) and 6 (content). Turns out there is a new gpt.js function as well
googletag.setConfig({ pps: { taxonomies: { 'IAB_AUDIENCE_1_1': {values: ['12', '13', '14']}, 'IAB_CONTENT_2_2': {values: ['22', '25', '57']}, } } });
Subsequent calls with new data should include all previous data to resurface, as they overwrite, not append
googletag.setConfig({ pps: { taxonomies: { 'IAB_AUDIENCE_1_1': {values: ['12', '13', '14','4', '5', '6']}, 'IAB_CONTENT_2_2': {values: ['22', '25', '57']}, } } });
Should we provide a single API call similar to setTargeting, set PPID, or handoff auction configs; perhaps setAdServerFPD(), or should we just always set it? I can't think of a reason people wouldn't want to set it, so I would be in favor of always setting it and perhaps offering a do not set config flag.
The text was updated successfully, but these errors were encountered: