Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prebid 9: stop supporting top level site, app, and device configuration #10747

Closed
dgirardi opened this issue Nov 20, 2023 · 0 comments · Fixed by #11522
Closed

Prebid 9: stop supporting top level site, app, and device configuration #10747

dgirardi opened this issue Nov 20, 2023 · 0 comments · Fixed by #11522
Assignees
@dgirardi
Labels
9.0 API Change

Comments

@dgirardi
Copy link
Collaborator

Description

Currently one can setConfig({device: X}) and/or setConfig({ortb2: {device: Y}}), and we have some logic that merges the two before sending them to adapters.

Our documentation suggests using orbt2 with a caveat that it has only been supported since version 4.29. At some point we should remove support for the top-level options altogether.
@patmmccann patmmccann moved this from Triage to Blocked in Prebid.js Tactical Issues table Dec 4, 2023
@patmmccann patmmccann mentioned this issue Jan 16, 2024
Closed
@patmmccann patmmccann moved this from Blocked to Ready for Dev in Prebid.js Tactical Issues table May 9, 2024
@dgirardi dgirardi self-assigned this May 20, 2024
@dgirardi dgirardi mentioned this issue May 20, 2024
Merged
1 task
@dgirardi dgirardi linked a pull request May 20, 2024 that will close this issue
Prebid 9: stop supporting top level app/site/device FPD config #11522
Merged
1 task
@patmmccann patmmccann moved this from Ready for Dev to PR submitted in Prebid.js Tactical Issues table May 22, 2024
@github-project-automation github-project-automation bot moved this from PR submitted to Done in Prebid.js Tactical Issues table May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dgirardi dgirardi

Labels
9.0 API Change
Projects
Prebid.js Tactical Issues table
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Prebid 9: stop supporting top level app/site/device FPD config dgirardi/Prebid.js
2 participants
@patmmccann @dgirardi