Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify formatting query string functions #10515

Closed
JoshuaRogan opened this issue Sep 21, 2023 · 2 comments
Closed

Unify formatting query string functions #10515

JoshuaRogan opened this issue Sep 21, 2023 · 2 comments

Comments

@JoshuaRogan
Copy link

Type of issue

Feature Request

Description

Currently, there are two separate functions which transform properties into a formatted query string:

https://github.com/prebid/Prebid.js/blob/master/src/utils.js#L111-L118
https://github.com/prebid/Prebid.js/blob/master/src/utils.js#L841-L848--> Doesn't properly encode (Fixed: Quick Fix Downstream)

Ideally, we should not be using multiple query string formatting functions. This would be a good opportunity to unify and potentially update to use URLSearchParams(https://developer.mozilla.org/en-US/docs/Web/API/URLSearchParams)

Other information

#10514

@patmmccann
Copy link
Collaborator

What do you mean when you say "this would be a good opportunity"? Do you mean the prebid 9 release?

@patmmccann
Copy link
Collaborator

This is work is not planned.

@patmmccann patmmccann closed this as not planned Won't fix, can't repro, duplicate, stale May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

2 participants