Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GumGum Bid Adapter: Not Passing GPP Consent Object as string #10469

Closed
robertrmartinez opened this issue Sep 11, 2023 · 3 comments · Fixed by #10530
Closed

GumGum Bid Adapter: Not Passing GPP Consent Object as string #10469

robertrmartinez opened this issue Sep 11, 2023 · 3 comments · Fixed by #10530
Labels

Comments

@robertrmartinez
Copy link
Collaborator

Type of issue

[X] - Bug

Description

When GPP consent is constructed by the gumgum adapter it is set as an object.

But the gumgum adapter sends a GET with query string params.

So this gppConsent object needs to be serialized into a JSON string, OR sent as separate fields.

I do not assume to know what the GumGum adserver expects, so I cannot make this change for them. (Though if I was a betting man, I would bet it just needs to be JSON.stringify-ed)

Steps to reproduce

Here is an example:

image

And the code:

    if (gppConsent) {
      data.gppConsent = {
        gppString: bidderRequest.gppConsent.gppString,
        gpp_sid: bidderRequest.gppConsent.applicableSections
      }
    } else if (!gppConsent && bidderRequest?.ortb2?.regs?.gpp) {
      data.gppConsent = {
        gppString: bidderRequest.ortb2.regs.gpp,
        gpp_sid: bidderRequest.ortb2.regs.gpp_sid
      };
    }
@robertrmartinez
Copy link
Collaborator Author

@MartinGumGum As the last person with an edit to the Gum Gum adapter I figured I would tag you!

@MartinGumGum
Copy link
Contributor

Hi @robertrmartinez, could you please send the link where you saw this bug so I can reproduce the issue? and thank you for noticing this.

@robertrmartinez
Copy link
Collaborator Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging a pull request may close this issue.

3 participants