Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Many 404 errors since : Sec-Browsing-Topics in 8.9 #10458

Closed
david-societe opened this issue Sep 11, 2023 · 9 comments
Closed

Many 404 errors since : Sec-Browsing-Topics in 8.9 #10458

david-societe opened this issue Sep 11, 2023 · 9 comments

Comments

@david-societe
Copy link

Type of issue

Lot of 404 errors in prebid sequence since [https://github.com//pull/10340]

Description

Prebid is trying to fetch my domain url with an object at the end (alledgally when trying to browseTopics).
-> GET https://www.dev3.societe.com/[object%20Object]
Returning a lot of 404 errors in the process

Related to this feature on 8.9 :
refactor ajax.js to use fetch instead of XHR
automatically pass browsingTopics: true to fetch, for all bidder requests, when the transmitUfpd activity is allowed

No other changes in configuration

Platform details

PREBID > 8.8

@patmmccann
Copy link
Collaborator

patmmccann commented Sep 11, 2023

Are you an endpoint maintainer? Which one? I cannot find a module named societe?

@david-societe
Copy link
Author

david-societe commented Sep 11, 2023 via email

@dgirardi
Copy link
Collaborator

dgirardi commented Sep 11, 2023

Can we have a test page? Or your adapter's buidRequests code?

@david-societe
Copy link
Author

david-societe commented Sep 11, 2023

you can test here : https://www.societe.com/#debug

thx a lot

@dgirardi
Copy link
Collaborator

The issue is that page monkey-patches the Request constructor with a version that does not have the same API:

image

and with that PR, we switched Prebid's network code from XHR to fetch & Request.

I am not sure what our options are here - is that monkey-patching necessary, and how commonly used is it?

@patmmccann patmmccann moved this from Triage to Needs OP in Prebid.js Tactical Issues table Sep 11, 2023
@dgirardi
Copy link
Collaborator

looking a bit more at that code, I wonder: is the monkey-patching unintentional? (as in, is that just a function named Request, that just happens to overwrite the browser's)?

if possible, I suggest either renaming that to something else, or wrapping that entire file in an IIFE (e.g. instead of [code], have (function(){[code]})()). The latter may not work if elsewhere you are relying on those symbols being put in the global namespace.

@david-societe
Copy link
Author

Thx a lot for your help.
I'm going to ask my CTO and try to fix the problem.

@patmmccann
Copy link
Collaborator

@david-societe are we all set?

@david-societe
Copy link
Author

david-societe commented Sep 11, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

3 participants