Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Position of header element changes when navigating to Bootcamp link #88

Closed
prasadhonrao opened this issue Oct 21, 2024 · 6 comments
Closed
Labels
bug Something isn't working
Milestone

Comments

@prasadhonrao
Copy link
Owner

When navigating to the Bootcamp link from other sections of the site, the position of the header element changes unexpectedly. This should not happen, and the header should remain in the same position across all pages.

@prasadhonrao prasadhonrao added the bug Something isn't working label Oct 21, 2024
@prasadhonrao prasadhonrao added this to the v1 milestone Oct 21, 2024
@AkankshShigwan
Copy link
Contributor

AkankshShigwan commented Oct 21, 2024

  • When navigate to bootcamps page from any another page header position getting change -> was happening because loader taking more space => resolved
  • new issue found -> when you navigate from page which have scroll bar to page which don't have scroll bar the header fluctuates => my suggestion was to remove scroll bar and add down arrow (@prasadhonrao what do you think....)
    like :
    Screenshot 2024-10-21 234703

@prasadhonrao
Copy link
Owner Author

Good analysis @AkankshShigwan.

We should assume that some of these pages will have vertical scroll bar as content will flow from top to bottom, even for bootcamp details page. Eventually we will have pagination implemented at the bottom of the bootcamps page which will help us to limit number of bootcamps we display on home page.

We should not have a down arrow to navigate as that is not a standard practice in web.

@AkankshShigwan
Copy link
Contributor

@prasadhonrao, ok so I have then hidden the scroll bar (page which scroll only scroll bar is hidden) to resolve these issues is it correct ?

@prasadhonrao
Copy link
Owner Author

@AkankshShigwan Not really. If the page contains any data (for e.g. footer) which is not visible to the user, then scroll bar is the indication that there is some additional data and user can scroll to it, so we should not hide the scroll bar.

If you visit websites like facebook and twitter login page, they also show the scroll bar even though there is no additional content at the bottom of the page so you have that much width already allocated for scroll bar. Additionally they also show sticky header which makes it easy to navigate through different pages.

Can you analyze something on those lines pls?

@AkankshShigwan
Copy link
Contributor

@prasadhonrao in the evening meeting we will discuss this clearly as I have many questions.

prasadhonrao added a commit that referenced this issue Oct 24, 2024
PR-90-  Update index.css to show scrollbar on all pages and adjust height of images

Closes Position of header element changes when navigating to Bootcamp link #88
@prasadhonrao
Copy link
Owner Author

Closed by PR 90

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

No branches or pull requests

2 participants