Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a setting to enable mono playback. #59

Open
wants to merge 1,397 commits into
base: master
Choose a base branch
from
Open
Changes from 1 commit
Commits
Show all changes
1397 commits
Select commit Hold shift + click to select a range
ee642f3
preferences: fix typo
recursive-rat4 May 19, 2013
4fab9f1
port last_folder to PraghaPreferences
recursive-rat4 May 19, 2013
306b204
Fix compilation due undeclared error.
matiasdelellis May 19, 2013
6c3a7e8
lastfm: don't double update mobj
recursive-rat4 May 19, 2013
2d396f1
Remove unused PraghaMusicobject
matiasdelellis May 20, 2013
4913601
D'Oh!. Fix change album tag in track list.
matiasdelellis May 21, 2013
f27f84f
D'Oh. Fix pango errors when edit title on current playlist
matiasdelellis May 23, 2013
51768a1
notify: some modularization
recursive-rat4 May 24, 2013
aa47907
move unique_instance to cwin
recursive-rat4 May 24, 2013
d0bf03b
cdda: avoid global state
recursive-rat4 May 24, 2013
90440d9
move first_run to cwin
recursive-rat4 May 24, 2013
e060f3a
eliminate struct con_state
recursive-rat4 May 24, 2013
b3bd5bc
drop gstreamer 0.10
recursive-rat4 Jan 22, 2013
bccbe56
backend: simplify code
recursive-rat4 Feb 18, 2013
ac605db
Port lastfm_support and lastfm_user to PraghaPreferences.
matiasdelellis Jun 25, 2013
efafdb5
update README
recursive-rat4 Jun 26, 2013
27829c1
notify: less depend on cwin
recursive-rat4 Jul 11, 2013
3f639d6
Equalizer: Use global PraghaPreferences instead depend on cwin.
matiasdelellis Jul 18, 2013
dc0fbaf
Use a struct to save all nedeed to equalizer dialgog.
matiasdelellis Jul 18, 2013
43c08fe
Use the struct to reduce arguments in functions.
matiasdelellis Jul 18, 2013
aeee8a7
Remove gtk_dialog_run()
matiasdelellis Jul 18, 2013
eaa0f15
The equalizer dialog no need to be modal.
matiasdelellis Jul 18, 2013
badbad4
Move the handler to menubar.
matiasdelellis Jul 18, 2013
cc06556
Show, but ignore the changes in dialog when no has equalizer in backend.
matiasdelellis Jul 18, 2013
4897e1e
No need save the dialog widget.
matiasdelellis Jul 18, 2013
6ee50ef
D'Oh!. ;)
matiasdelellis Jul 18, 2013
f8744dd
Bind bands and widgets properties in a sinlge function.
matiasdelellis Jul 18, 2013
c116ff5
Hide cwin members a bit. At least in the equalizer.
matiasdelellis Jul 18, 2013
fcaa837
Port lastfm password to PraghaPreferences. (So basic.)
matiasdelellis Jul 19, 2013
53b23e5
Port installed_version to PraghaPreferences.
matiasdelellis Jul 19, 2013
792adb4
POTFILES: pragha-equalizer.c -> pragha-equalizer-dialog.c
matiasdelellis Jul 20, 2013
fa4a7f7
Port start_mode to PraghaPreferences
matiasdelellis Jul 20, 2013
bd1c061
Port window size an position tu PraghaPrefrences. Remove struct con_p…
matiasdelellis Jul 20, 2013
5f0471a
Clean pragha.h
matiasdelellis Jul 20, 2013
d8b9931
Move a couple of init directly to main.
matiasdelellis Jul 20, 2013
8676d3b
Move session management support to their own file.
matiasdelellis Jul 21, 2013
4b39777
Move save window size, position and sidebar size to gui_free()
matiasdelellis Jul 22, 2013
0794b82
Save visible columns and sizes directly when free PraghaPlaylist.
matiasdelellis Jul 22, 2013
a2cea10
Directly save soft volume when change it.
matiasdelellis Jul 22, 2013
b68b6eb
Also save playlist when free PraghaPlaylist.
matiasdelellis Jul 22, 2013
db0ee2c
Rename some functiona related to close pragha.
matiasdelellis Jul 22, 2013
6310a93
Clean pragha.h
matiasdelellis Jul 22, 2013
1c7cbbb
Clean the creation of the menubar.
matiasdelellis Jul 24, 2013
0a62709
Remove the binding of visible lateral panel properties of init_gui.
matiasdelellis Jul 24, 2013
c437a5e
Move the binding of visible status bar conf within your construction.
matiasdelellis Jul 24, 2013
0b4c3b6
Move the connection of backend signals to main just after create it.
matiasdelellis Jul 25, 2013
07ddd05
Clean main().. Try leaving basic initializations in main, and the con…
matiasdelellis Jul 25, 2013
9a1c3f5
Fix typo and use pragha_application_* prefix to manage the struct cwin.
matiasdelellis Jul 25, 2013
6d4c707
menubar: fix build without lastfm
recursive-rat4 Jul 28, 2013
9679f42
toolbar: Only clean the creation of track info widgets.
matiasdelellis Jul 29, 2013
3293056
keybinder is for X11 only
recursive-rat4 Jul 29, 2013
04f4466
Reworked the creation of the main window.
matiasdelellis Jul 29, 2013
869f836
D'Oh!.
matiasdelellis Jul 29, 2013
811c4b2
Remove PreferecesWidgets from cwin.
matiasdelellis Jul 29, 2013
dcca7d0
First effoct to gobjectify PraghaToolbar.
matiasdelellis Jul 30, 2013
fcaae5c
Use signals to show-current-album-art.
matiasdelellis Jul 30, 2013
b51830a
Edit current song using signals.
matiasdelellis Jul 30, 2013
0240980
Seek playback clicking on progress bar using signals.
matiasdelellis Jul 30, 2013
22fcd71
Add volume property to PraghaToolbar, and synchronize this with the B…
matiasdelellis Jul 30, 2013
72a656e
Remove unused pragha_toolbar_get_volume_button()
matiasdelellis Jul 30, 2013
7ca1027
Remove a lot of cwin of PraghaToolbar
matiasdelellis Jul 30, 2013
81f5eb9
Add timer-remaning-mode as property of PraghaToolbar.
matiasdelellis Jul 30, 2013
f77c178
Add explicit pragha_toolbar_set_image_album_art() and move some code.
matiasdelellis Jul 30, 2013
13ca8a2
Unfllscreen using signals.
matiasdelellis Jul 30, 2013
9f050f3
D'OOOOh!.
matiasdelellis Jul 30, 2013
f838b8a
Fix delay of show the seek event in gui.
matiasdelellis Jul 31, 2013
0b1e282
Fix delay when change to time remaning mode..
matiasdelellis Jul 31, 2013
cdc7468
Use g_signal_connect_swapped to avoid one line wrapers..
matiasdelellis Aug 2, 2013
ec04fbe
Clean a little and silent warning when compiling
matiasdelellis Aug 2, 2013
89d8fd3
Remove all code to get the album art from pragha-toolbar.c
matiasdelellis Aug 2, 2013
e3b5340
Fix unable to automatically play another song in pragha.
matiasdelellis Aug 3, 2013
3b0a2de
Only silent warning when compile..
matiasdelellis Aug 4, 2013
eee2a7e
Private toolbar.
matiasdelellis Aug 5, 2013
22c454b
silence warnings if try to open empty albumart
recursive-rat4 Aug 5, 2013
5e2e1e1
Init the status bar when construct the window, and store in PraghaWin…
matiasdelellis Aug 5, 2013
1d2c779
Try to remove cwin of menu bar. Now at least in the construction.
matiasdelellis Aug 5, 2013
9cae66f
playback: don't prematurely update gui on seek
recursive-rat4 Aug 8, 2013
72c3cd8
backend: emit tick when seeked
recursive-rat4 Aug 8, 2013
e50816f
menubar: fix small mem leak
recursive-rat4 Aug 9, 2013
494840d
preferences: fix small mem leaks
recursive-rat4 Aug 9, 2013
1d8a40a
lastfm: remove duplicated code
recursive-rat4 Aug 11, 2013
5b21835
move some lastfm code to pragha-lastfm.c
recursive-rat4 Aug 11, 2013
be5b969
fix build
recursive-rat4 Aug 16, 2013
4e494f2
Fix regression on 1.1.2: Return to import playlists..
matiasdelellis Aug 22, 2013
05c2eb9
utils: optimize loading pixbuf from memory
recursive-rat4 Aug 22, 2013
aa64b53
toolbar: cleanup includes
recursive-rat4 Aug 22, 2013
04e9e01
utils: add missing const
recursive-rat4 Aug 22, 2013
fd519a7
extract PraghaArtCache
recursive-rat4 Aug 22, 2013
c7c6109
add support for embedded album art
recursive-rat4 Aug 22, 2013
fc55b40
art-cache: fix for case artist or album cointains slash
recursive-rat4 Aug 23, 2013
875c358
glyr: rename a function
recursive-rat4 Aug 24, 2013
428792e
move some lastfm code to pragha-lastfm.c
recursive-rat4 Aug 24, 2013
8b5c406
Improves the way to determine if the files are a song or playlist whi…
matiasdelellis Aug 26, 2013
7b9942b
Improve way to determine if the files are a song or playlist when add…
matiasdelellis Aug 27, 2013
3d7ec54
Fix undefined reference to `GDK_IS_X11_DISPLAY'
matiasdelellis Aug 27, 2013
c685910
Fix libxfce4ui version to compile with gtk3
matiasdelellis Aug 27, 2013
330679b
Tiny rework of main menu construct and usage..
matiasdelellis Aug 27, 2013
cbb5a0b
Add plugins actions (Latsfm) in menubar dynamically..
matiasdelellis Aug 27, 2013
cc229f9
pragha_lastfm: Use type_def to clean, implement connect and disconnec…
matiasdelellis Aug 27, 2013
eb77e8b
Add and remove lastfm options dynamically when dis/connect it.
matiasdelellis Aug 27, 2013
47b7078
pragha_lastfm: Stop get lastfm user and password continuously
matiasdelellis Aug 27, 2013
ea7a9d7
menubar: fix runtime warning
recursive-rat4 Aug 27, 2013
b24233c
The same with tools on playlist popup menu.
matiasdelellis Aug 27, 2013
9b161e1
D'Oh!. Update lastfm menu on backend changes.
matiasdelellis Aug 27, 2013
c5ba394
Also add generics functions to remove plugins from menubar and popup …
matiasdelellis Aug 27, 2013
d1baf58
Use a unique function to sensitive actions.. and clean the code a bit..
matiasdelellis Aug 27, 2013
1b71078
Save preferences when activate any GtkEntry of dialog..
matiasdelellis Aug 27, 2013
28bb5c2
D'Oh!. Fix seg fault.
matiasdelellis Aug 28, 2013
a04fcab
Set merge_id to zero when remove plugin actions..
matiasdelellis Aug 28, 2013
a430ce1
Fix toggle lastfm state every time that open preferences..
matiasdelellis Aug 28, 2013
0e424d7
Fix bad condition to sensitive "Add favorites" menu action..
matiasdelellis Aug 28, 2013
adb5175
Always add a end separator to "pluging" menu actions..
matiasdelellis Sep 3, 2013
91beb73
filter-dialog: fix use-after-free
recursive-rat4 Sep 5, 2013
f030c4c
filter-dialog: fix memory leak
recursive-rat4 Sep 5, 2013
e045944
preferences: fix copy-paste mistake
recursive-rat4 Sep 15, 2013
8dffdd7
filter-dialog: avoid unnecessary copying
recursive-rat4 Sep 15, 2013
0cb01d9
library-pane: avoid unnecessary copying
recursive-rat4 Sep 15, 2013
c168c4b
move PraghaSearchEntry to separate file
recursive-rat4 Sep 15, 2013
09c57cd
search-entry: make callbacks static
recursive-rat4 Sep 15, 2013
b4270fd
search-entry: use GBinding for preferences
recursive-rat4 Sep 15, 2013
6c423ff
search-entry: update sensitivity of clear button in one place
recursive-rat4 Sep 15, 2013
af0a5a2
search-entry: make icons consistent with GtkSearchEntry
recursive-rat4 Sep 15, 2013
7020f23
filter-dialog: remove unneeded underscore
recursive-rat4 Sep 15, 2013
c71ffaa
Fix coverity defects: Unused pointer value (UNUSED_VALUE)
matiasdelellis Sep 18, 2013
90064f2
Fix coverity defects: Uninitialized scalar variable (UNINIT)
matiasdelellis Sep 18, 2013
7dd3e2b
Fix coverity defects: Division or modulo by zero (DIVIDE_BY_ZERO)
matiasdelellis Sep 18, 2013
eb8c88a
Fix coverity defects: Unchecked return value (CHECKED_RETURN)
matiasdelellis Sep 18, 2013
e4acaea
Fix coverity defects: Unchecked return value from library (CHECKED_RE…
matiasdelellis Sep 18, 2013
3ee0ef2
Fix coverity defects: Dereference before null check (REVERSE_INULL)
matiasdelellis Sep 18, 2013
3238832
Fix coverity defects: Resource leak (RESOURCE_LEAK)
matiasdelellis Sep 18, 2013
fbf6087
Fix coverity defects: Explicit null dereferenced (FORWARD_NULL)
matiasdelellis Sep 18, 2013
42aee2c
pragha-tag-dialog: Fix always select comment tag as changed..
matiasdelellis Sep 19, 2013
5ab4a3c
Remove gtk_dialog_run() on statistics dialog.
matiasdelellis Sep 19, 2013
e265201
Remove cwin from set style view options..
matiasdelellis Sep 20, 2013
410e81b
First effoct to gobjectify PraghaLibraryPane.
matiasdelellis Sep 20, 2013
48c766f
D'Oh!.. =)
matiasdelellis Sep 20, 2013
856c047
Renable rename, remove and export..
matiasdelellis Sep 20, 2013
ecbd257
Renable edit tags from library pane.
matiasdelellis Sep 20, 2013
47293a1
Renable delete from hdd and db..
matiasdelellis Sep 20, 2013
2811706
Renable change style of library view..
matiasdelellis Sep 20, 2013
47ac482
Remove PraghaWindow. Complicating more than it solves..
matiasdelellis Sep 20, 2013
433b26b
Use always pragha_window_get_mainwindow (cwin);
matiasdelellis Sep 20, 2013
c694489
Use always pragha_window_get_pixbuf_app(cwin);
matiasdelellis Sep 20, 2013
9e8ee5b
Remove old function prototype..
matiasdelellis Sep 20, 2013
3117406
Always use pragha_application_get_backend (cwin);
matiasdelellis Sep 20, 2013
679bafc
Use Backend pointer of callbacks..
matiasdelellis Sep 20, 2013
b05b42d
Private menu_ui_manager a bit..
matiasdelellis Sep 20, 2013
09fd12e
First effoct to gobjectify PraghaPlaylist.. Nothing works!.
matiasdelellis Sep 21, 2013
ab73543
Renable queue, dequeue, remove, crop and clear options..
matiasdelellis Sep 21, 2013
aafde71
Save playlist, save selection and tools no need changes..
matiasdelellis Sep 21, 2013
256978a
Rename cplaylist in cwin to playlist and private it..
matiasdelellis Sep 21, 2013
891c399
Chiao pragha_window*(). Is useles..
matiasdelellis Sep 21, 2013
26c099b
pragha_application_quit() no need cwin!.
matiasdelellis Sep 21, 2013
850f6f8
pragha-playback: Removes path references. Does not have to know this!.
matiasdelellis Sep 22, 2013
bf5730f
Fix pixbuf state in current playlist.
matiasdelellis Sep 22, 2013
d7241b3
Add a singnal to play a song double-clicking playlist..
matiasdelellis Sep 23, 2013
e0cc26a
Restore Copy tags from playlist option..
matiasdelellis Sep 23, 2013
e44e17b
Restore: Edit tracks on playlist with dialog..
matiasdelellis Sep 23, 2013
bbbe7dc
Set sidebar style to library in gtk3.. =)
matiasdelellis Sep 23, 2013
061f855
Partially fix the color of dialogs headers..
matiasdelellis Sep 24, 2013
c1b0961
Fix saving of the playlist and preferences.
matiasdelellis Sep 24, 2013
c05735f
Merge branch 'GobjectivicePlaylist'
matiasdelellis Sep 24, 2013
401f001
Remove public access to cwin->cgnome_media_keys and cwin->keybinder.
matiasdelellis Sep 24, 2013
b3634dd
Hide cwin->preferences..
matiasdelellis Sep 24, 2013
82ee247
Hide cwin->cdbase..
matiasdelellis Sep 24, 2013
f441295
Hide cwin->scanner
matiasdelellis Sep 24, 2013
59ff966
Hide cwin->art_cache.
matiasdelellis Sep 24, 2013
8c34e14
Hide cwin->library..
matiasdelellis Sep 24, 2013
c5d4325
Update statusbar playtime with a signal from playlist when change..
matiasdelellis Sep 24, 2013
7a1f444
Fix: gtk_range_get_adjustment: assertion 'GTK_IS_RANGE (range)' failed
matiasdelellis Sep 24, 2013
2a70261
Fix save fuse folders option when use a library style.
matiasdelellis Sep 25, 2013
aa3e1b2
Add simple appdata.xml to gnome-software..
matiasdelellis Sep 26, 2013
bae4e7a
Fix GLib-GObject-WARNING **: invalid unclassed pointer in cast to 'Gt…
matiasdelellis Sep 26, 2013
ed1c5c4
Remove cwin->first_run
matiasdelellis Sep 26, 2013
238fffc
add pragha_application_is_first_run()
recursive-rat4 Sep 26, 2013
a20d322
playlist: fix destruction
recursive-rat4 Sep 26, 2013
57afbde
Private cwin->mpris2, and removes cwin of arguments in mpris code!.
matiasdelellis Sep 26, 2013
caea368
fix empty status bar at startup
recursive-rat4 Sep 26, 2013
59648bf
Gobjective status_icon.. A quick patch to remove/hide cwin->systray_m…
matiasdelellis Sep 26, 2013
9ba2745
Remove some cwin->mainwinodow uses.
matiasdelellis Sep 26, 2013
92f17ec
Private pixbuf_app, menu_ui_manager, infobox and pane.
matiasdelellis Sep 26, 2013
a6ecd4a
D'Oh!.
matiasdelellis Sep 26, 2013
487071a
Private notify struct..
matiasdelellis Sep 26, 2013
afdaaae
Privatice cwin->clastfm.
matiasdelellis Sep 27, 2013
eace679
Privatice PraghaGlyr from cwin..
matiasdelellis Sep 27, 2013
9c7e45d
statusicon: fix destruction
recursive-rat4 Sep 27, 2013
83db325
rename struct con_win to PraghaApplication
recursive-rat4 Sep 27, 2013
7f9942d
Disable recursively fetch playlists with TotemPlParser
matiasdelellis Sep 27, 2013
eef4d79
playlist: make a function static
recursive-rat4 Oct 5, 2013
bcbdfbd
use g_list_free_full()
recursive-rat4 Oct 5, 2013
e3ca8ab
playlists-mgmt: fix memory leak
recursive-rat4 Oct 5, 2013
5282f00
mpris: fix memory leak
recursive-rat4 Oct 5, 2013
7df5604
playlist: fix memory leaks
recursive-rat4 Oct 5, 2013
33460d3
Set to 0 timeout_ids when remove it!!
matiasdelellis Oct 10, 2013
7e14b0a
Remove especial popup to emthy playlists.
matiasdelellis Oct 11, 2013
a02648d
D'Oh!. Fix four seg fault in systray!!!
matiasdelellis Oct 11, 2013
0152fa0
mpris: fix leak at shutdown
recursive-rat4 Oct 13, 2013
823607e
turn into GApplication
recursive-rat4 Jun 12, 2012
b065af3
cmdline is now handled by primary instance
recursive-rat4 Jun 12, 2012
3f95c7d
uniqueness is now controlled by GApplication
recursive-rat4 Jun 12, 2012
df91a84
drop unused dbus code
recursive-rat4 Jun 12, 2012
4fd8e2c
less mess with mainloop
recursive-rat4 Oct 13, 2013
d96ec61
don't use gtk_init_add()
recursive-rat4 Oct 13, 2013
29a5665
Merge branch 'gapplication-rebased'
recursive-rat4 Oct 24, 2013
635b3c7
Hide remaining members and move PraghaApplication struct to pragha.c
matiasdelellis Oct 24, 2013
efccb2d
Clean unused includes.
matiasdelellis Oct 24, 2013
1d7781c
Use enum as argument instead gint.
matiasdelellis Oct 25, 2013
c9fddb3
gnome-media-keys: add deprecation comment
recursive-rat4 Oct 25, 2013
df84e74
Change enum player_state to PraghaBackendState.
matiasdelellis Oct 25, 2013
80dc72e
Change enum file_type to PraghaMusicType.
matiasdelellis Oct 25, 2013
129d50b
Change enum playlist_type to PraghaPlaylistType.
matiasdelellis Oct 25, 2013
a2ffebd
Change enum node_type to LibraryNodeType and private it.
matiasdelellis Oct 25, 2013
28c48ec
Split enum playlist_mgmt into PraghaPlaylistAction and PraghaPlaylist…
matiasdelellis Oct 25, 2013
f7a2580
Rename enum LASTFM_QUERY_TYPE to LastfmQueryType and use it!!.
matiasdelellis Oct 25, 2013
ffbd626
Change enum playlist_action to PraghaUpdateAction.
matiasdelellis Oct 25, 2013
959c6b1
Remove some prototypes from pragha.playlist.h
matiasdelellis Oct 25, 2013
7325be3
Add pragha-dnd.c/h to manage basic drag and drop.
matiasdelellis Oct 25, 2013
99f966e
Revert "update README"
matiasdelellis Oct 31, 2013
8cc488b
Revert "backend: simplify code"
matiasdelellis Oct 31, 2013
a6ee678
Revert "drop gstreamer 0.10"
matiasdelellis Oct 31, 2013
c9063fc
Fix gstreamer 0.10 support but set default the gstreamer 1.0
matiasdelellis Nov 1, 2013
de071c4
Fix make distcheck.
matiasdelellis Nov 5, 2013
ada5a81
Fix make distcheck.
matiasdelellis Nov 5, 2013
711fcb8
Pragha 1.2.rc
matiasdelellis Nov 5, 2013
d9389d3
Fix thread safety when reading tags.
matiasdelellis Nov 7, 2013
ff90ef5
Fix thread safety when reading tags.
matiasdelellis Nov 7, 2013
3acfdc6
Unregister dbus objects when disbale mpris2 support.
matiasdelellis Nov 8, 2013
e74d11d
Unregister dbus objects when disbale mpris2 support.
matiasdelellis Nov 8, 2013
4d56ee1
Add transifex rules to Makefile. Never remember these commands!. haha.
matiasdelellis Nov 8, 2013
6de1d03
Add transifex rules to Makefile. Never remember these commands!. haha.
matiasdelellis Nov 8, 2013
9ea6dfc
Always use "playlist-set-track" signal to set new songs on backend.
matiasdelellis Nov 20, 2013
0bd9396
Clear previous songs when finalize playlist or explicitly stop playback.
matiasdelellis Nov 22, 2013
3c18d54
Also use "playlist-set-track" to notity new song.
matiasdelellis Nov 22, 2013
53e0f82
tags-mgmt: fix mismatched free()/g_free()
recursive-rat4 Nov 22, 2013
e9a7c8f
mpris: roll registration ids into array
recursive-rat4 Nov 22, 2013
0fdfb12
Merge branch 'master' of https://github.com/matiasdelellis/pragha
matiasdelellis Nov 23, 2013
73dfe93
Ony rename a few of functions..
matiasdelellis Nov 24, 2013
f6eca42
Rename get_next_random_track() to get_next_ANY!!!_random_track().
matiasdelellis Nov 27, 2013
36a4fdb
Remove PraghaUpdateAction from PraghaPlaylist..
matiasdelellis Nov 27, 2013
e2cf61b
Always use "playlist-set-track" signal to set new songs on backend.
matiasdelellis Nov 20, 2013
1e47753
Clear previous songs when finalize playlist or explicitly stop playback.
matiasdelellis Nov 22, 2013
5a856f4
tags-mgmt: fix mismatched free()/g_free()
recursive-rat4 Nov 22, 2013
f9c5026
mpris: roll registration ids into array
recursive-rat4 Nov 22, 2013
022800f
Also use "playlist-set-track" to notity new song.
matiasdelellis Nov 22, 2013
dad9263
Ony rename a few of functions..
matiasdelellis Nov 24, 2013
a93411c
Rename get_next_random_track() to get_next_ANY!!!_random_track().
matiasdelellis Nov 27, 2013
cbd8ce2
Remove PraghaUpdateAction from PraghaPlaylist..
matiasdelellis Nov 27, 2013
44db42d
Added a setting to enable mono playback.
mvdkwast Dec 3, 2013
8a72394
Merge branch 'pragha-1.2' of github.com:mvdkwast/pragha
mvdkwast Dec 3, 2013
aa7832b
Fix compiler warnings
mvdkwast Dec 3, 2013
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
pragha_application_quit() no need cwin!.
Move a pair of handlers..
matiasdelellis committed Sep 21, 2013
commit 26c099b1866877812c5877254c07d9028579240a
44 changes: 2 additions & 42 deletions src/pragha-menubar.c
Original file line number Diff line number Diff line change
@@ -703,7 +703,7 @@ void edit_tags_playing_action(GtkAction *action, struct con_win *cwin)

void quit_action(GtkAction *action, struct con_win *cwin)
{
pragha_application_quit (cwin);
pragha_application_quit ();
}

/* Handler for 'Search Playlist' option in the Edit menu */
@@ -802,47 +802,7 @@ void update_library_action(GtkAction *action, struct con_win *cwin)
pragha_scanner_update_library(cwin->scanner);
}

/* Handler for 'Add All' action in the Tools menu */

void add_libary_action(GtkAction *action, struct con_win *cwin)
{
PraghaPlaylist *playlist;
GList *list = NULL;
PraghaMusicobject *mobj;

/* Query and insert entries */

set_watch_cursor (pragha_application_get_window(cwin));

const gchar *sql = "SELECT id FROM LOCATION";
PraghaPreparedStatement *statement = pragha_database_create_statement (cwin->cdbase, sql);

while (pragha_prepared_statement_step (statement)) {
gint location_id = pragha_prepared_statement_get_int (statement, 0);
mobj = new_musicobject_from_db (cwin->cdbase, location_id);

if (!mobj)
g_warning ("Unable to retrieve details for"
" location_id : %d",
location_id);
else {
list = g_list_prepend (list, mobj);
}

pragha_process_gtk_events ();
}

pragha_prepared_statement_free (statement);

remove_watch_cursor (pragha_application_get_window(cwin));

if (list) {
list = g_list_reverse(list);
playlist = pragha_application_get_playlist (cwin);
pragha_playlist_append_mobj_list (playlist, list);
g_list_free(list);
}
}
/* Handler for remove, crop and clear action in the Tools menu */

static void
pragha_menubar_remove_playlist_action (GtkAction *action, struct con_win *cwin)
2 changes: 1 addition & 1 deletion src/pragha-mpris.c
Original file line number Diff line number Diff line change
@@ -186,7 +186,7 @@ static void mpris_Root_Raise (GDBusMethodInvocation *invocation, GVariant* param

static void mpris_Root_Quit (GDBusMethodInvocation *invocation, GVariant* parameters, struct con_win *cwin)
{
pragha_application_quit (cwin);
pragha_application_quit ();
g_dbus_method_invocation_return_value (invocation, NULL);
}

77 changes: 45 additions & 32 deletions src/pragha-playlist.c
Original file line number Diff line number Diff line change
@@ -99,6 +99,13 @@ struct _PraghaPlaylist {

G_DEFINE_TYPE(PraghaPlaylist, pragha_playlist, GTK_TYPE_SCROLLED_WINDOW)

/*
* Prototypes
*/

static void pragha_playlist_queue_handler (PraghaPlaylist *cplaylist);
static void pragha_playlist_dequeue_handler (PraghaPlaylist *cplaylist);

/*
* playlist_context_menu calbacks
*/
@@ -177,6 +184,40 @@ static GtkToggleActionEntry playlist_context_toggles_entries[] = {
TRUE}
};

/*
* Menu action callbacks.
*/

static void
queue_current_playlist (GtkAction *action, PraghaPlaylist *playlist)
{
pragha_playlist_queue_handler (playlist);
}

static void
dequeue_current_playlist (GtkAction *action, PraghaPlaylist *playlist)
{
pragha_playlist_dequeue_handler (playlist);
}

static void
remove_from_playlist (GtkAction *action, PraghaPlaylist *playlist)
{
pragha_playlist_remove_selection (playlist);
}

static void
crop_current_playlist (GtkAction *action, PraghaPlaylist *playlist)
{
pragha_playlist_crop_selection (playlist);
}

static void
current_playlist_clear_action (GtkAction *action, PraghaPlaylist *playlist)
{
pragha_playlist_remove_all (playlist);
}

/* Update playback state pixbuf */

static void
@@ -1182,7 +1223,8 @@ GtkTreePath* current_playlist_get_actual(PraghaPlaylist *cplaylist)

/* Dequeue selected rows from current playlist */

void pragha_playlist_dequeue_handler(PraghaPlaylist *cplaylist)
static void
pragha_playlist_dequeue_handler (PraghaPlaylist *cplaylist)
{
GtkTreeSelection *selection;
GList *list;
@@ -1196,16 +1238,10 @@ void pragha_playlist_dequeue_handler(PraghaPlaylist *cplaylist)
}


/* Dequeue selected rows from current playlist */

void dequeue_current_playlist (GtkAction *action, PraghaPlaylist *playlist)
{
pragha_playlist_dequeue_handler (playlist);
}

/* Queue selected rows from current playlist */

void pragha_playlist_queue_handler(PraghaPlaylist *cplaylist)
static void
pragha_playlist_queue_handler (PraghaPlaylist *cplaylist)
{
GtkTreeModel *model;
GtkTreeSelection *selection;
@@ -1235,13 +1271,6 @@ void pragha_playlist_queue_handler(PraghaPlaylist *cplaylist)
g_list_free (list);
}

/* Queue selected rows from current playlist */

void queue_current_playlist (GtkAction *action, PraghaPlaylist *playlist)
{
pragha_playlist_queue_handler (playlist);
}

/* Toglle queue state of selection on current playlist. */

void toggle_queue_selected_current_playlist (PraghaPlaylist *cplaylist)
@@ -1352,11 +1381,6 @@ pragha_playlist_remove_selection (PraghaPlaylist *playlist)
pragha_playlist_update_statusbar_playtime (playlist);
}

static void remove_from_playlist (GtkAction *action, PraghaPlaylist *playlist)
{
pragha_playlist_remove_selection (playlist);
}

/* Crop selected rows from current playlist */

void
@@ -1433,11 +1457,6 @@ pragha_playlist_crop_selection (PraghaPlaylist *playlist)
g_slist_free(to_delete);
}

void crop_current_playlist (GtkAction *action, PraghaPlaylist *playlist)
{
pragha_playlist_crop_selection (playlist);
}

/* Handle key press on current playlist view.
* Based on Totem Code*/

@@ -1530,12 +1549,6 @@ pragha_playlist_remove_all (PraghaPlaylist *playlist)
pragha_playlist_update_statusbar_playtime (playlist);
}

void
current_playlist_clear_action (GtkAction *action, PraghaPlaylist *playlist)
{
pragha_playlist_remove_all (playlist);
}

/* Update a list of references in the current playlist */

gboolean
2 changes: 1 addition & 1 deletion src/pragha-statusicon.c
Original file line number Diff line number Diff line change
@@ -196,7 +196,7 @@ systray_next_action (GtkAction *action, struct con_win *cwin)
static void
systray_quit (GtkAction *action, struct con_win *cwin)
{
pragha_application_quit (cwin);
pragha_application_quit ();
}

static void
4 changes: 2 additions & 2 deletions src/pragha-window.c
Original file line number Diff line number Diff line change
@@ -50,15 +50,15 @@ pragha_close_window(GtkWidget *widget, GdkEvent *event, struct con_win *cwin)
gtk_window_iconify (GTK_WINDOW (cwin->mainwindow));
}
else {
pragha_application_quit (cwin);
pragha_application_quit ();
}
return TRUE;
}

void
pragha_destroy_window(GtkWidget *widget, struct con_win *cwin)
{
pragha_application_quit (cwin);
pragha_application_quit ();
}

void
2 changes: 1 addition & 1 deletion src/pragha.c
Original file line number Diff line number Diff line change
@@ -190,7 +190,7 @@ pragha_application_get_menubar (struct con_win *cwin)
}

void
pragha_application_quit (struct con_win *cwin)
pragha_application_quit (void)
{
gtk_main_quit();

2 changes: 1 addition & 1 deletion src/pragha.h
Original file line number Diff line number Diff line change
@@ -156,6 +156,6 @@ gint init_options(struct con_win *cwin, int argc, char **argv);

/* Close */

void pragha_application_quit (struct con_win *cwin);
void pragha_application_quit (void);

#endif /* PRAGHA_H */