Added a setting to enable mono playback. #59

mvdkwast · 2013-12-03T19:24:55Z

This adds a setting to the audio preferences that allows for mono playback. This is useful when you only have one speaker, which would normally cause the content of the right track to be lost.

leftover from 56fac40

TODO: * Port lastfm password without adding the property to PraghaPreferences. * So, not save it in memory. Only search when necessary. * Maybe save the hexadecimal characters to hide the password.

TODO: Extend it.

TODO: Remove control of password when uptate now playing.

Before, When update the library, and add external files breaking pragha!. Nobody notice???? ¬¬

Based on yumex Makefile.. =)

I almost went crazy thinking that there was something wrong with the latest patches!. In resume, when the playlist ends, returns to play but completely random!. No repeats previous playlist!.

matiasdelellis · 2013-12-03T20:48:35Z

Hi @mvdkwast
First, thanks for helping!. =)

But a doubt .. When is necessary use mono?.
Because a speaker is broke? or is there any real application?.
Correct me if I'm wrong.. but currently mono soundcards are not used.. No?.

If you have a stereo soundcard and want to use a single speaker would be more interesting use audioparonama and merge it within the equalizer... (You can get the same directly on pulseaudio.. haha)

http://gstreamer.freedesktop.org/data/doc/gstreamer/head/gst-plugins-good-plugins/html/gst-plugins-good-plugins-audiopanorama.html

p.s: Another thing, be careful with the use of tabs and spaces.. and avoid adding comnits that are not relevant to your pull request!. 😅

mvdkwast · 2013-12-03T21:27:02Z

Hi,

The mono option is useful when you want to listen to music on a guitar
amplifier, to practice for instance. Especially some older albums have
instruments hard-panned to one side, which means that sometimes you won't
hear the solo you want to practice ! Another usecase is that if you have
two speakers that aren't placed nicely aournd the listeners (for lack of
space for instance), mono can sound better than stereo.

Mixing left and right to mono is not the same thing as panning the signal
to one side which looses part of the signal, and silences a speaker if you
have two, so audiopanorama is not an option. I was tired of routing pragha
through jackd just to achieve mono sound, and after checking a few players
I didn't find any that was so fast and had a library, so I decided to take
a look at the source.

I'm not sure the equalizer would be the best place to toggle between mono
and stereo because it requires a restart as implemented now, so better keep
the audio options together (or implement hot audio restarting, which seems
a lot of work for not so much benefit), Also, if you think this option is
too much of a niche, by all means leave it out, and keep pragha as lean and
mean as it is now :)

Sorry for the commit mess, I'm not very used to git and did not find how to
revert those commits to clean them up !

On Tue, Dec 3, 2013 at 9:48 PM, matiasdelellis [email protected]:

Hi @mvdkwast https://github.com/mvdkwast
First, thanks for helping!. =)

But a doubt .. When is necessary use mono?.
Because a speaker is broke? or is there any real application?.
Correct me if I'm wrong.. but currently mono soundcards are not used..
No?.

If you have a stereo soundcard and want to use a single speaker would be
more interesting use audioparonama and merge it within the equalizer...
(You can get the same directly on pulseaudio.. haha)

http://gstreamer.freedesktop.org/data/doc/gstreamer/head/gst-plugins-good-plugins/html/gst-plugins-good-plugins-audiopanorama.html

p.s: Another thing, be careful with the use of tabs and spaces.. and avoid
adding comnits that are not relevant to your pull request!. [image:
😅]

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/59#issuecomment-29749715
.

matiasdelellis · 2013-12-03T21:40:48Z

The mono option is useful when you want to listen to music on a guitar amplifier, to practice for instance. Especially some older albums have instruments hard-panned to one side, which means that sometimes you won't hear the solo you want to practice ! Another usecase is that if you have two speakers that aren't placed nicely aournd the listeners (for lack of space for instance), mono can sound better than stereo.

Ohh.. Ok.. This is a real application where it can be useful.. 😊

Sorry for the commit mess, I'm not very used to git and did not find how to revert those commits to clean them up !

Do not worry..

Well .. It really is not an intrusive change .. So I invite you to continue working .. 😉

matiasdelellis · 2013-12-03T21:42:44Z

ps: Makes all changes based on master!. Not from 1.2, because I will not add functionality there..

recursive-rat4 and others added 30 commits May 19, 2013 18:51

preferences: fix typo

ee642f3

port last_folder to PraghaPreferences

4fab9f1

Fix compilation due undeclared error.

306b204

lastfm: don't double update mobj

6c3a7e8

leftover from 56fac40

Remove unused PraghaMusicobject

2d396f1

D'Oh!. Fix change album tag in track list.

4913601

D'Oh. Fix pango errors when edit title on current playlist

f27f84f

notify: some modularization

51768a1

move unique_instance to cwin

aa47907

cdda: avoid global state

d0bf03b

move first_run to cwin

90440d9

eliminate struct con_state

e060f3a

drop gstreamer 0.10

b3bd5bc

backend: simplify code

bccbe56

Port lastfm_support and lastfm_user to PraghaPreferences.

ac605db

TODO: * Port lastfm password without adding the property to PraghaPreferences. * So, not save it in memory. Only search when necessary. * Maybe save the hexadecimal characters to hide the password.

update README

efafdb5

notify: less depend on cwin

27829c1

Equalizer: Use global PraghaPreferences instead depend on cwin.

3f639d6

Use a struct to save all nedeed to equalizer dialgog.

dc0fbaf

Use the struct to reduce arguments in functions.

43c08fe

Remove gtk_dialog_run()

aeee8a7

The equalizer dialog no need to be modal.

eaa0f15

Move the handler to menubar.

badbad4

Show, but ignore the changes in dialog when no has equalizer in backend.

cc06556

No need save the dialog widget.

4897e1e

D'Oh!. ;)

6ee50ef

Bind bands and widgets properties in a sinlge function.

f8744dd

Hide cwin members a bit. At least in the equalizer.

c116ff5

TODO: Extend it.

Port lastfm password to PraghaPreferences. (So basic.)

fcaa837

TODO: Remove control of password when uptate now playing.

Port installed_version to PraghaPreferences.

53b23e5

matiasdelellis and others added 26 commits November 7, 2013 12:24

Fix thread safety when reading tags.

d9389d3

Before, When update the library, and add external files breaking pragha!. Nobody notice???? ¬¬

Fix thread safety when reading tags.

ff90ef5

Before, When update the library, and add external files breaking pragha!. Nobody notice???? ¬¬

Unregister dbus objects when disbale mpris2 support.

3acfdc6

Unregister dbus objects when disbale mpris2 support.

e74d11d

Add transifex rules to Makefile. Never remember these commands!. haha.

4d56ee1

Based on yumex Makefile.. =)

Add transifex rules to Makefile. Never remember these commands!. haha.

6de1d03

Based on yumex Makefile.. =)

Always use "playlist-set-track" signal to set new songs on backend.

9ea6dfc

Clear previous songs when finalize playlist or explicitly stop playback.

0bd9396

Also use "playlist-set-track" to notity new song.

3c18d54

tags-mgmt: fix mismatched free()/g_free()

53e0f82

mpris: roll registration ids into array

e9a7c8f

Merge branch 'master' of https://github.com/matiasdelellis/pragha

0fdfb12

Ony rename a few of functions..

73dfe93

Rename get_next_random_track() to get_next_ANY!!!_random_track().

f6eca42

I almost went crazy thinking that there was something wrong with the latest patches!. In resume, when the playlist ends, returns to play but completely random!. No repeats previous playlist!.

Remove PraghaUpdateAction from PraghaPlaylist..

36a4fdb

Always use "playlist-set-track" signal to set new songs on backend.

e2cf61b

Clear previous songs when finalize playlist or explicitly stop playback.

1e47753

tags-mgmt: fix mismatched free()/g_free()

5a856f4

mpris: roll registration ids into array

f9c5026

Also use "playlist-set-track" to notity new song.

022800f

Ony rename a few of functions..

dad9263

Rename get_next_random_track() to get_next_ANY!!!_random_track().

a93411c

I almost went crazy thinking that there was something wrong with the latest patches!. In resume, when the playlist ends, returns to play but completely random!. No repeats previous playlist!.

Remove PraghaUpdateAction from PraghaPlaylist..

cbd8ce2

Added a setting to enable mono playback.

44db42d

Merge branch 'pragha-1.2' of github.com:mvdkwast/pragha

8a72394

Fix compiler warnings

aa7832b

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added a setting to enable mono playback. #59

Added a setting to enable mono playback. #59

mvdkwast commented Dec 3, 2013

matiasdelellis commented Dec 3, 2013

mvdkwast commented Dec 3, 2013

matiasdelellis commented Dec 3, 2013

matiasdelellis commented Dec 3, 2013

Added a setting to enable mono playback. #59

Are you sure you want to change the base?

Added a setting to enable mono playback. #59

Conversation

mvdkwast commented Dec 3, 2013

matiasdelellis commented Dec 3, 2013

mvdkwast commented Dec 3, 2013

matiasdelellis commented Dec 3, 2013

matiasdelellis commented Dec 3, 2013