Support all audio files recognized by GNOME's GIO #102
Conversation
src/pragha-file-utils.c
Outdated
| const gchar *mime_asf[] = {"video/x-ms-asf", "audio/x-ms-wma", "application/x-ext-wma", NULL}; | ||
| const gchar *mime_mp4 [] = {"audio/x-m4a", "application/x-ext-m4a", NULL}; | ||
| const gchar *mime_ape [] = {"application/x-ape", "audio/ape", "audio/x-ape", NULL}; | ||
| const gchar *mime_tracker[] = {"audio/x-mod", "audio/x-xm", "application/x-ext-mod", NULL}; |
There was a problem hiding this comment.
Although not 100% supported, you should leave this for Windows... You can only detect audio files by extensions... application/x-ext-???
There was a problem hiding this comment.
Right, probably I should leave an array of supported mimetypes which don't begin with "audio/"
There was a problem hiding this comment.
👍
As codecs are also distributed in the installer, perhaps we can restrict it better...
|
Hi @wymiatacz It is a change that I've been thinking a while.. But the problem to solve is that every time that save a tag change pragha try to save tags using taglib regardless if support it or if it is a CD or an MTP device where not work.. Let me see as a complement to solve this too .... 😉 Thanks for all, |
This allows playing files supported by GStreamer regardless of whether their MIME type is present in Pragha's internal white lists and even if unsupported by taglib
|
Hi @matiasdelellis |
|
Hi @wymiatacz |
|
I just uploaded a new version of the change a few days ago and asked you for a comment. This time the change proposal is much less, let's say, invasive than the original one. If you tell me what's wrong with it, I can try to improve it further. With my change, the "Edit track information" option is still available and shows the tag edition dialog even if the track is unsupported by taglib (therefore clicking OK has no effect). The error in saving tags is silently ignored. Is this the only problem, or do you see others? Do you have a proposal how it should behave? Graying out this option for files unsupported by taglib? |
|
Hi @wymiatacz I just wanted to plan a more comprehensive proposal:
But in principle, adding an option to "Allow partially supported files" as a warning, would be enough to accept your proposal. |
(apart from playlists, which need special handling)
This should cover all future issues similar to #58.