Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handling of (some) double quotes is broken #317

Open
RichMorin opened this issue Dec 20, 2019 · 3 comments
Open

handling of (some) double quotes is broken #317

RichMorin opened this issue Dec 20, 2019 · 3 comments
Assignees
Milestone

Comments

@RichMorin
Copy link
Contributor

Earmark likes to generate matching sets of "smart quotes", but it doesn't always get them right.
The closing quote in the second instance below is actually another opening quote:

iex(1)> foo = """            
...(1)> for example, "_" and "-" ...
...(1)> """
"For example, \"_\" and \"-\" ...\n"
iex(2)> Earmark.as_html(foo)        
{:ok, "<p>For example, “_” and “-“ …</p>\n", []}
@RobertDober
Copy link
Collaborator

Thank you for reporting this, looks like an extension of #280, I guess I need to increase the priority of this one.

@RobertDober
Copy link
Collaborator

Imported test case from #280

   test/acceptance/html1/escape_test.exs:18

@RobertDober
Copy link
Collaborator

Hmm this needs some major rewrite of the renderer, regexen do not seem to cut it.
Sorry

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants