Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AVX2 backend not enabled by default #574

Closed
dkostic opened this issue Dec 23, 2024 · 3 comments
Closed

AVX2 backend not enabled by default #574

dkostic opened this issue Dec 23, 2024 · 3 comments
Labels
bug Something isn't working build

Comments

@dkostic
Copy link

dkostic commented Dec 23, 2024

Describe the bug
Since this commit the AVX2 backend doesn't compile by default. My platform is a c7i EC2 instance with Intel(R) Xeon(R) Platinum 8488C, running Ubuntu 22.04 with gcc 11.4.0.

Platform: x86_64 Linux

Compiler: gcc 11.4.0

How to reproduce
Steps to reproduce the behavior:

make clean; make -j

One of the easiest ways to confirm that the AVX2 backend is not enabled is to run any of the benchmarks and compare the numbers against the expected ones (https://pq-code-package.github.io/mlkem-native/dev/bench/). Otherwise, you can insert #error fail_the_build_if_this_is_compiled for example here and try to build the library which will succeed, meaning that the AVX2 backend is not compiled.

Expected behavior
A clear and concise description of what you expected to happen.

Additional context
Add any other context about the problem here.

@dkostic dkostic added the bug Something isn't working label Dec 23, 2024
@dkostic dkostic mentioned this issue Dec 23, 2024
4 tasks
@hanno-becker
Copy link
Contributor

hanno-becker commented Dec 24, 2024

Thank you @dkostic for reporting this. We should have caught this in CI which even tests with this machine, but is likely not checking the backend. Interestingly, the benchmarks did not show a regression, so the AVX2 backend must still work in the bench tests on c7i.

Can you confirm whether the build fails with FORCE_X86_64?

@hanno-becker
Copy link
Contributor

@dkostic can you confirm that #578 fixed the issue for you?

@dkostic
Copy link
Author

dkostic commented Dec 24, 2024

Thanks for quick reaction! The fix in #578 works on my machine as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working build
Projects
None yet
Development

No branches or pull requests

2 participants