Test: Use make instead of tests in functest action
#571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hanno-becker
force-pushed
the
test_simpl
branch
3 times, most recently
from
de80448 to
9528852
Compare
hanno-becker
changed the title
make check_func instead of tests func in functest actionmake instead of tests in functest action
hanno-becker
force-pushed
the
test_simpl
branch
3 times, most recently
from
0befca0 to
59cb691
Compare
|
@mkannwischer This fails in case noopt is disabled because then you do a make clean before check namespace. I guess one should do a check namespace after opt and noopt separately, and suitably conditioned. Can you do that? |
Previously, `tests` would automatically detect which QEMU binary to use for emulation. With this commit, this is instead made explicit in the logic of the workflow. This is a step towards simplifying the `tests` script and eventually replacing it by calls to `make`. Signed-off-by: Hanno Becker <[email protected]>
Signed-off-by: Hanno Becker <[email protected]>
Signed-off-by: Hanno Becker <[email protected]>
mkannwischer
force-pushed
the
test_simpl
branch
from
c4b5182 to
5e5d347
Compare
|
On second thought, I think the convenience of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
functestworkflow to usemakeonly #567This PR replaces calls to
testsin thefunctestCI action by direct invocations ofmake. There is a bit of explicit repetition, which we may want to remove: IIRC, we always want to run all tests, so the splitting intofunc/acvp/nistkat/katis redundant, and we could as well just callmake checkall.The PR does not yet remove the increasingly obsolete test-functionality of
tests. Note that the benchmarking logic is more involved and may merit keepingtests(perhaps renamed tobench).