Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup native and emulated test CI #27

Closed
mkannwischer opened this issue Mar 27, 2024 · 6 comments · Fixed by #60
Closed

Setup native and emulated test CI #27

mkannwischer opened this issue Mar 27, 2024 · 6 comments · Fixed by #60
Labels
enhancement New feature or request

Comments

@mkannwischer
Copy link
Contributor

https://github.com/pq-code-package/mlkem-c-aarch64/pull/22 adds native test.

In addition to that I'd like to add support for cross-compilation and testing in qemu. That should also allow running the tests in the Github CI.
We do have something similar in https://github.com/slothy-optimizer/pqax that could give some inspriation.
There is CI there too: slothy-optimizer/pqax#4

@mkannwischer mkannwischer added the enhancement New feature or request label Mar 27, 2024
@cothan
Copy link
Contributor

cothan commented Mar 27, 2024

Good idea. After #22 merge I will add a build test, also hashsum to ensure the correctness.

@hanno-becker
Copy link
Contributor

Once we integrate AArch64 assembly, #22 will need updating rather than amending, right?

@hanno-becker hanno-becker changed the title Add cross-compilation and tests using qemu Setup native and emulated test CI May 30, 2024
@hanno-becker
Copy link
Contributor

hanno-becker commented May 30, 2024

So, what we want for the test CI is:

@mkannwischer Agree?

@potsrevennil
Copy link
Contributor

Hi, yes I'm on emulated tests on x86 linux runners

@mkannwischer
Copy link
Contributor Author

Yes, that sounds good to me!

@hanno-becker
Copy link
Contributor

hanno-becker commented Jun 12, 2024

@potsrevennil potsrevennil linked a pull request Jun 13, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants