Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn about performance regressions #202

Closed
hanno-becker opened this issue Oct 6, 2024 · 5 comments
Closed

Warn about performance regressions #202

hanno-becker opened this issue Oct 6, 2024 · 5 comments
Assignees
Labels
ci enhancement New feature or request
Milestone

Comments

@hanno-becker
Copy link
Contributor

It would be nice if the benchmarking CI could compare new vs. main performance numbers and warn, through a comment on the PR, if there's a target experiencing a major (>5%, say?) regression.

@hanno-becker hanno-becker added the enhancement New feature or request label Oct 6, 2024
@hanno-becker
Copy link
Contributor Author

@potsrevennil Do you know how to do this?

@potsrevennil
Copy link
Contributor

potsrevennil commented Oct 6, 2024

I'm thinking about using git note although I've never used it before

For example, we could add summary of the benchmarking result (whenever there's a new commit on main) via git note, which add notes to commit without touching commit itself, thus would not pollute the history.
Then we could just simply diff the notes between different commits on the main branch

But this might required some times to trial and error

@potsrevennil
Copy link
Contributor

potsrevennil commented Oct 6, 2024

Oh, maybe there's an easier way
the benchmarkaction/github-action-benchmark provided alert-threshold and comment-on-alert, this might be able to achieve what we want ?

@hanno-becker
Copy link
Contributor Author

@potsrevennil That sounds promising indeed!

@mkannwischer
Copy link
Contributor

Done by #424

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants