From 602ebfc59f1114c3cb1e01d44abe1136a87823e3 Mon Sep 17 00:00:00 2001 From: Hanno Becker Date: Sat, 16 Nov 2024 16:52:39 +0000 Subject: [PATCH] Bench: Store non-opt benchmarks on GH pages Until now, we only pushed benchmarks for optimized code to the github pages. That was the wrong decision, as we are now curious to understand (a) where mlkem-native's pure-C performance stands in comparison to the reference implementation, and (b) how it has evolved over time, esp. in light of restructurings we made for the CBMC proofs. Ultimately, we should retroactively conduct & push non-opt benchmarks. For now, this commit merely enables pushing benchmarking results to GH pages for non-optimized code. Care needs to be taken to not mess up with existing optimized benchmarks by changing their name. Thus, we keep the previous names (which matched the target name, e.g. "Graviton 3"), but append " (no-opt)" in case we benchmarked the C backend. Signed-off-by: Hanno Becker --- .github/workflows/bench.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/bench.yml b/.github/workflows/bench.yml index 25facd2b8..04527f0e0 100644 --- a/.github/workflows/bench.yml +++ b/.github/workflows/bench.yml @@ -110,6 +110,6 @@ jobs: archflags: ${{ matrix.target.archflags }} cflags: ${{ matrix.target.cflags }} opt: ${{ matrix.opt.value }} - store_results: ${{ matrix.opt.value && github.repository_owner == 'pq-code-package' && github.ref == 'refs/heads/main' }} # Only store optimized results - name: ${{ matrix.target.name }} + store_results: ${{ github.repository_owner == 'pq-code-package' && github.ref == 'refs/heads/main' }} # Only store optimized results + name: ${{ matrix.target.name }}${{ !matrix.opt.value && " (no-opt)" }} secrets: inherit