Refactor

powdr-labs · Dec 4, 2024 · aa08a54 · aa08a54
1 parent 44212d6
commit aa08a54
Showing 1 changed file with 8 additions and 3 deletions.
diff --git a/backend/src/mock/polynomial_constraint_checker.rs b/backend/src/mock/polynomial_constraint_checker.rs
@@ -1,7 +1,7 @@
 use std::{collections::BTreeMap, fmt};
 
 use powdr_ast::{
-    analyzed::{Identity, PolynomialIdentity},
+    analyzed::{AlgebraicExpression, Identity, PolynomialIdentity},
     parsed::visitor::AllChildren,
 };
 use powdr_executor::witgen::{
@@ -70,8 +70,13 @@ impl<'a, F: FieldElement> PolynomialConstraintChecker<'a, F> {
                 let result = evaluator.evaluate(&identity.expression);
 
                 if result != F::zero() {
-                    let used_variables = identity.all_children().filter_map(|child| {
-                        child.try_into().ok().map(|_: AlgebraicVariable| child)
+                    let used_variables = identity.all_children().filter(|expr| match expr {
+                        AlgebraicExpression::Reference(_)
+                        | AlgebraicExpression::PublicReference(_)
+                        | AlgebraicExpression::Challenge(_) => true,
+                        AlgebraicExpression::Number(_)
+                        | AlgebraicExpression::BinaryOperation(_)
+                        | AlgebraicExpression::UnaryOperation(_) => false,
                     });
                     Some(FailingPolynomialConstraint {
                         row,