Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary onCommand events from package.json #35

Open
gadenbuie opened this issue Apr 22, 2024 · 0 comments · May be fixed by #36
Open

Remove unnecessary onCommand events from package.json #35

gadenbuie opened this issue Apr 22, 2024 · 0 comments · May be fixed by #36
Assignees
@gadenbuie

Comments

@gadenbuie
Copy link
Collaborator

https://github.com/posit-dev/pyshiny-vscode/blob/3635a936a35859af82b3a02bf8246142d0631635/package.json#L18-L24

The onCommand events are flagged by linters:

This activation event can be removed for extensions targeting engine version ^1.75 as VS Code will generate these automatically from your package.json contribution declarations.

I think this is safe: VS Code 1.75 was released in January 2023.
@gadenbuie gadenbuie self-assigned this Apr 22, 2024
gadenbuie added a commit that referenced this issue Apr 22, 2024
@gadenbuie
Remove unnecessary onCommand events from package.json
6cb7cdb 
Fixes #35
@gadenbuie gadenbuie linked a pull request Apr 22, 2024 that will close this issue
Draft
@gadenbuie gadenbuie added this to the v0.2.0 milestone Apr 24, 2024
@gadenbuie gadenbuie removed this from the v0.2.0 milestone May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gadenbuie gadenbuie

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove unnecessary onCommand events from package.json posit-dev/shiny-vscode
1 participant
@gadenbuie