Skip to content

Commit

Permalink
Merge pull request #1895 from posit-dev/mm-disable-openvsx
Browse files Browse the repository at this point in the history
Fix VSIX targets so extension publishing in CI will work
  • Loading branch information
mmarchetti authored Jun 27, 2024
2 parents c6a9858 + 29abf7f commit 931216c
Show file tree
Hide file tree
Showing 5 changed files with 14 additions and 10 deletions.
2 changes: 0 additions & 2 deletions .github/workflows/publish.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,6 @@ jobs:
with:
pat: ${{ secrets.OPEN_VSX_TOKEN }}
extensionFile: ${{ steps.get-extension-path.outputs.extension_path }}
target: ${{ matrix.target }}
skipDuplicate: true

- name: Publish to Visual Studio Marketplace
Expand All @@ -52,5 +51,4 @@ jobs:
registryUrl: https://marketplace.visualstudio.com
pat: ${{ secrets.VSCE_PAT }}
extensionFile: ${{ steps.get-extension-path.outputs.extension_path }}
target: ${{ matrix.target }}
skipDuplicate: true
6 changes: 6 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,12 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## [1.1.2]

### Fixed

- Fixed VSIX target OS and architecture (#1895)

## [1.1.1]

### Fixed
Expand Down
10 changes: 5 additions & 5 deletions docs/installation.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,11 +7,11 @@ VSCode.

Download and install the VSCode extension.

- For Arm MacOS: [publisher-1.1.1-darwin-arm64.vsix](https://cdn.posit.co/publisher/releases/tags/v1.1.1/publisher-1.1.1-darwin-arm64.vsix)
- For Intel MacOS: [publisher-1.1.1-darwin-amd64.vsix](https://cdn.posit.co/publisher/releases/tags/v1.1.1/publisher-1.1.1-darwin-amd64.vsix)
- For Windows: [publisher-1.1.1-windows-amd64.vsix](https://cdn.posit.co/publisher/releases/tags/v1.1.1/publisher-1.1.1-windows-amd64.vsix)
- For Arm Linux: [publisher-1.1.1-linux-arm64.vsix](https://cdn.posit.co/publisher/releases/tags/v1.1.1/publisher-1.1.1-linux-arm64.vsix)
- For Intel Linux: [publisher-1.1.1-linux-amd64.vsix](https://cdn.posit.co/publisher/releases/tags/v1.1.1/publisher-1.1.1-linux-amd64.vsix)
- For Arm MacOS: [publisher-1.1.2-darwin-arm64.vsix](https://cdn.posit.co/publisher/releases/tags/v1.1.2/publisher-1.1.2-darwin-arm64.vsix)
- For Intel MacOS: [publisher-1.1.2-darwin-amd64.vsix](https://cdn.posit.co/publisher/releases/tags/v1.1.2/publisher-1.1.2-darwin-amd64.vsix)
- For Windows: [publisher-1.1.2-windows-amd64.vsix](https://cdn.posit.co/publisher/releases/tags/v1.1.2/publisher-1.1.2-windows-amd64.vsix)
- For Arm Linux: [publisher-1.1.2-linux-arm64.vsix](https://cdn.posit.co/publisher/releases/tags/v1.1.2/publisher-1.1.2-linux-arm64.vsix)
- For Intel Linux: [publisher-1.1.2-linux-amd64.vsix](https://cdn.posit.co/publisher/releases/tags/v1.1.2/publisher-1.1.2-linux-amd64.vsix)

To learn how to install a `.vsix` file, see the [Install from a
VSIX](https://code.visualstudio.com/docs/editor/extension-marketplace#_install-from-a-vsix)
Expand Down
2 changes: 1 addition & 1 deletion extensions/vscode/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,6 @@ file.
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## [1.1.1]
## [1.1.2]

- Initial beta release
4 changes: 2 additions & 2 deletions extensions/vscode/justfile
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ alias t := test

_ci := env_var_or_default("CI", "false")

_debug := env_var_or_default("DEBUG", "false")
_debug := env_var_or_default("DEBUG", _ci)

_with_debug := if _debug == "true" {
"set -x pipefail"
Expand Down Expand Up @@ -136,7 +136,7 @@ package os="$(just ../../os)" arch="$(just ../../arch)":
{{ _with_debug }}
just assert-binary-executable-exists
echo "info: getting package target platform..." 1>&2
target_platform=$(just package-target-platform)
target_platform=$(just package-target-platform {{ os }} {{ arch }})
echo "info: getting package output path..." 1>&2
path="$(just package-path)"
mkdir -p "$path"
Expand Down

0 comments on commit 931216c

Please sign in to comment.