Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

emphasis and link questions #17

Closed
cscheid opened this issue Sep 9, 2024 · 5 comments
Closed

emphasis and link questions #17

cscheid opened this issue Sep 9, 2024 · 5 comments

Comments

@cscheid
Copy link
Collaborator

cscheid commented Sep 9, 2024

I don't understand why we allow typefaces to change from base to headings, but not to emphasis or link.

And similarly to #16, I think the color configuration of these should be done by known names in color, and not in typography.

@gadenbuie
Copy link
Collaborator

gadenbuie commented Sep 9, 2024

We allow for selecting the typeface of three key content groups: base, headings and monospace. Base/headings are going to appear in 90+% of brand guidelines. Monospace is relevant to our data science use cases.

We could allow varying typeface for other fields for consistency, but that's much more of an edge case (from a design perspective) and not a common need.

I certainly see an argument for moving color of things like headings, emphasis, links, etc. to brand.color, but that wouldn't make sense for the background-color property. Ultimately, I don't think it would make sense to define foreground colors in one place and background colors in another, so I think they're better grouped together in typography.

@gadenbuie
Copy link
Collaborator

Looking at this section of the spec again, I think we should have bold and italic instead of emphasis, which would give us the following

typography:
  base:
  headings:
  monospace:
  bold:
  italic:
  link:

@cscheid
Copy link
Collaborator Author

cscheid commented Sep 9, 2024

I think we should have bold and italic instead of emphasis, which would give us the following

I like it. (We'll inevitably get a bug report about bold-italic, but I'm willing to live with that.)

What do you think about my color concerns?

@gadenbuie
Copy link
Collaborator

What do you think about my color concerns?

ICYMI I had thoughts about color and font family in a comment above.

@cscheid
Copy link
Collaborator Author

cscheid commented Sep 10, 2024

See #16.

@cscheid cscheid closed this as completed Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants