Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow config file to set what timezone for logs (And/Or turn off universal time) #193

Open
Kickbut101 opened this issue Nov 23, 2019 · 3 comments
Labels
enhancement pinned Prevent closing if stale

Comments

@Kickbut101
Copy link

Currently in Poshbot.psm1 (Version 12.0.0) line 117 is;
[datetime]$DateTime = (Get-Date).ToUniversalTime()

I understand this is probably convenient or useful to some. But I found it troublesome and a little bit annoying to try to figure out why all my timestamps made no sense while troubleshooting.

Expected Behavior

I can easily determine issues with the script by checking timestamps without wondering why they are all way off from my local time

Current Behavior

Time is "off" (at least to me)

Possible Solution

Allow the timestamp to be set to local time or to universaltime.

Your Environment

  • Module version used: 12.0.0
  • Operating System and PowerShell version: Win10. Though this issue is prevalent across all systems, due to it's nature.
@stale
Copy link

stale bot commented Jan 22, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jan 22, 2020
@devblackops devblackops added the pinned Prevent closing if stale label Jan 23, 2020
@stale stale bot removed the stale label Jan 23, 2020
@devblackops
Copy link
Member

@Kickbut101 We can probably make that a configuration option with UTC being the default. Make sense?

@Kickbut101
Copy link
Author

@Kickbut101 We can probably make that a configuration option with UTC being the default. Make sense?

That would totally work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement pinned Prevent closing if stale
Projects
None yet
Development

No branches or pull requests

2 participants