You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Unlike the rest of nova fields, this filter allows configuration only from the constructor. This makes it difficult to modify the behavior of say an extended child class to add additional features that don't really fit. While it can be done, it's kind of ugly as you have to modify the internal config array.
Would you be open to changes that allow configuration via chainable methods instead of (or in addition to) the constructor config?
For example, instead of setting the default date range via the config constructor param, it could be called instead like:
(new DateRangeFilter())
->withDefaultRange('90 days ago, 'today')
That example takes it a step further and allows variable date ranging as well based on carbon parsing, but you get the idea for allowing configuration in a bit clearer way.
The text was updated successfully, but these errors were encountered:
Unlike the rest of nova fields, this filter allows configuration only from the constructor. This makes it difficult to modify the behavior of say an extended child class to add additional features that don't really fit. While it can be done, it's kind of ugly as you have to modify the internal config array.
Would you be open to changes that allow configuration via chainable methods instead of (or in addition to) the constructor config?
For example, instead of setting the default date range via the config constructor param, it could be called instead like:
That example takes it a step further and allows variable date ranging as well based on carbon parsing, but you get the idea for allowing configuration in a bit clearer way.
The text was updated successfully, but these errors were encountered: