Exomiser 14 #142
Merged
Exomiser 14 #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EddieLF
approved these changes
Apr 29, 2024
There was a problem hiding this comment.
Approving assuming that the linting can be fixed. I don't really understand the error mypy is giving, is it related to this issue? python/mypy#10768
AFAIK because I've bundled the same python script into both exomiser builds, and neither folder was set up as a python module, mypy detects two files with the same name in the same namespace and cries. TBH this is a mostly non-python repo, so mypy as a pre-commit hook isn't very useful. I've solved/mitigated by adding an init.py, so each folder reads as a separate python module |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a separate build for Exomiser 14.X so as not to conflict with the current 13.X version (the two versions do not share db files, so these are incompatible)
Reliant on the data being sourced separately (see populationgenomics/references#55)