feat: a11y applet #1093
wash2ci.yml
on: pull_request
formatting
12s
linting
2m 42s
Annotations
10 warnings
|
taken reference of right operand:
cosmic-app-list/cosmic-app-list-config/src/lib.rs#L45
warning: taken reference of right operand
--> cosmic-app-list/cosmic-app-list-config/src/lib.rs:45:63
|
45 | if let Some(pos) = self.favorites.iter().position(|e| e == &id) {
| ^^^^^---
| |
| help: use the right value directly: `id`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref
= note: `#[warn(clippy::op_ref)]` on by default
|
|
unused import: `std::ops::Sub`:
cosmic-applet-notifications/src/subscriptions/dbus.rs#L4
warning: unused import: `std::ops::Sub`
--> cosmic-applet-notifications/src/subscriptions/dbus.rs:4:5
|
4 | use std::ops::Sub;
| ^^^^^^^^^^^^^
|
= note: `#[warn(unused_imports)]` on by default
|
|
this `if` statement can be collapsed:
cosmic-applet-audio/src/mouse_area.rs#L303
warning: this `if` statement can be collapsed
--> cosmic-applet-audio/src/mouse_area.rs:303:9
|
303 | / if !state.is_out_of_bounds {
304 | | if widget
305 | | .on_mouse_enter
306 | | .as_ref()
... |
317 | | }
318 | | }
| |_________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
= note: `#[warn(clippy::collapsible_if)]` on by default
help: collapse nested if block
|
303 ~ if !state.is_out_of_bounds && widget
304 + .on_mouse_enter
305 + .as_ref()
306 + .or(widget.on_mouse_exit.as_ref())
307 + .is_some() {
308 + if let Event::Mouse(mouse::Event::CursorMoved { .. }) = event {
309 + state.is_out_of_bounds = true;
310 + if let Some(message) = widget.on_mouse_exit.as_ref() {
311 + shell.publish(message.clone());
312 + }
313 + return event::Status::Captured;
314 + }
315 + }
|
|
|
variant `OpenSettings` is never constructed:
cosmic-applet-notifications/src/lib.rs#L95
warning: variant `OpenSettings` is never constructed
--> cosmic-applet-notifications/src/lib.rs:95:5
|
83 | enum Message {
| ------- variant in this enum
...
95 | OpenSettings,
| ^^^^^^^^^^^^
|
= note: `Message` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis
= note: `#[warn(dead_code)]` on by default
|
|
field `0` is never read:
cosmic-applet-audio/src/pulse.rs#L453
warning: field `0` is never read
--> cosmic-applet-audio/src/pulse.rs:453:16
|
453 | IterateErr(IterateResult),
| ---------- ^^^^^^^^^^^^^
| |
| field in this variant
|
= note: `#[warn(dead_code)]` on by default
help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field
|
453 | IterateErr(()),
| ~~
|
|
field `0` is never read:
cosmic-applet-audio/src/pulse.rs#L454
warning: field `0` is never read
--> cosmic-applet-audio/src/pulse.rs:454:16
|
454 | ContextErr(pulse::context::State),
| ---------- ^^^^^^^^^^^^^^^^^^^^^
| |
| field in this variant
|
help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field
|
454 | ContextErr(()),
| ~~
|
|
field `0` is never read:
cosmic-applet-audio/src/pulse.rs#L455
warning: field `0` is never read
--> cosmic-applet-audio/src/pulse.rs:455:18
|
455 | OperationErr(pulse::operation::State),
| ------------ ^^^^^^^^^^^^^^^^^^^^^^^
| |
| field in this variant
|
help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field
|
455 | OperationErr(()),
| ~~
|
|
field `0` is never read:
cosmic-applet-audio/src/pulse.rs#L456
warning: field `0` is never read
--> cosmic-applet-audio/src/pulse.rs:456:11
|
456 | PAErr(PAErr),
| ----- ^^^^^
| |
| field in this variant
|
help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field
|
456 | PAErr(()),
| ~~
|
|
field `0` is never read:
cosmic-applet-audio/src/pulse.rs#L458
warning: field `0` is never read
--> cosmic-applet-audio/src/pulse.rs:458:10
|
458 | Misc(&'a str),
| ---- ^^^^^^^
| |
| field in this variant
|
help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field
|
458 | Misc(()),
| ~~
|
|
fields `user_name`, `host_name`, `server_version`, `server_name`, and `cookie` are never read:
cosmic-applet-audio/src/pulse.rs#L811
warning: fields `user_name`, `host_name`, `server_version`, `server_name`, and `cookie` are never read
--> cosmic-applet-audio/src/pulse.rs:811:9
|
809 | pub struct ServerInfo {
| ---------- fields in this struct
810 | /// User name of the daemon process.
811 | pub user_name: Option<String>,
| ^^^^^^^^^
812 | /// Host name the daemon is running on.
813 | pub host_name: Option<String>,
| ^^^^^^^^^
814 | /// Version string of the daemon.
815 | pub server_version: Option<String>,
| ^^^^^^^^^^^^^^
816 | /// Server package name (usually “pulseaudio”).
817 | pub server_name: Option<String>,
| ^^^^^^^^^^^
...
825 | pub cookie: u32,
| ^^^^^^
|
= note: `ServerInfo` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis
|