From 4c5aea50c17d8c6facce8cc7f245bd7103d8841f Mon Sep 17 00:00:00 2001 From: Raffi Khatchadourian Date: Mon, 22 Jul 2024 12:32:31 -0400 Subject: [PATCH] Don't ignore tests. Instead, expected them to fail. --- .../python/ml/test/TestTensorflow2Model.java | 29 ++++++++++--------- 1 file changed, 15 insertions(+), 14 deletions(-) diff --git a/com.ibm.wala.cast.python.ml.test/source/com/ibm/wala/cast/python/ml/test/TestTensorflow2Model.java b/com.ibm.wala.cast.python.ml.test/source/com/ibm/wala/cast/python/ml/test/TestTensorflow2Model.java index 87a48194..61ba34da 100644 --- a/com.ibm.wala.cast.python.ml.test/source/com/ibm/wala/cast/python/ml/test/TestTensorflow2Model.java +++ b/com.ibm.wala.cast.python.ml.test/source/com/ibm/wala/cast/python/ml/test/TestTensorflow2Model.java @@ -39,7 +39,6 @@ import java.util.logging.Logger; import java.util.stream.Collectors; import java.util.stream.Stream; -import org.junit.Ignore; import org.junit.Test; /** Test TF2 APIs. */ @@ -3042,14 +3041,14 @@ public void testDecoratedMethod() throws ClassHierarchyException, CancelExceptio test("tf2_test_decorated_method.py", "f", 1, 1, 2); } - @Ignore("Enable once once https://github.com/wala/ML/issues/188 is fixed.") - @Test + /** Test https://github.com/wala/ML/issues/188. */ + @Test(expected = AssertionError.class) public void testDecoratedMethod2() throws ClassHierarchyException, CancelException, IOException { test("tf2_test_decorated_method2.py", "f", 1, 1, 2); } - @Ignore("Enable once once https://github.com/wala/ML/issues/190 is fixed.") - @Test + /** Test https://github.com/wala/ML/issues/190. */ + @Test(expected = AssertionError.class) public void testDecoratedMethod3() throws ClassHierarchyException, CancelException, IOException { test("tf2_test_decorated_method3.py", "raffi", 1, 1, 2); } @@ -3079,17 +3078,19 @@ public void testDecoratedMethod8() throws ClassHierarchyException, CancelExcepti test("tf2_test_decorated_method8.py", "f", 1, 1, 2); } - /** This decorator isn't defined. Thus, we shouldn't have a CG node for it. */ - @Ignore( - "We now require nodes for functions under test. Otherwise, a test could pass even though the" - + " function doesn't exist.") - @Test + /** + * This decorator isn't defined. Thus, we shouldn't have a CG node for it. + * + *

We now require nodes for functions under test. Otherwise, a test could pass even though the + * function doesn't exist. + */ + @Test(expected = AssertionError.class) public void testDecoratedMethod9() throws ClassHierarchyException, CancelException, IOException { test("tf2_test_decorated_method9.py", "f", 0, 0); } - @Ignore("Enable once once https://github.com/wala/ML/issues/190 is fixed.") - @Test + /** Test https://github.com/wala/ML/issues/190. */ + @Test(expected = AssertionError.class) public void testDecoratedMethod10() throws ClassHierarchyException, CancelException, IOException { test("tf2_test_decorated_method10.py", "f", 1, 1, 2); } @@ -3105,8 +3106,8 @@ public void testDecoratedMethod12() throws ClassHierarchyException, CancelExcept test("tf2_test_decorated_method12.py", "f", 0, 0); } - @Ignore("Enable once once https://github.com/wala/ML/issues/190 is fixed.") - @Test + /** Test https://github.com/wala/ML/issues/190. */ + @Test(expected = AssertionError.class) public void testDecoratedMethod13() throws ClassHierarchyException, CancelException, IOException { test("tf2_test_decorated_method13.py", "f", 1, 1, 2); }