Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build failure pertaining to multi-file projects #374

Open
khatchad opened this issue Oct 31, 2024 · 6 comments
Open

Build failure pertaining to multi-file projects #374

khatchad opened this issue Oct 31, 2024 · 6 comments
Assignees
@khatchad
Labels
bug Something isn't working
Milestone
Prototype impleme...

Comments

@khatchad
Copy link
Member

I am currently seeing the following failure on 7fa82aa:

Results:

Failures: 
  HybridizeFunctionRefactoringTest.testPythonSideEffects59:6122->testPythonSideEffects:5408->lambda$55:5411 Function: f() should have side-effects. expected:<true> but was:<false>
  HybridizeFunctionRefactoringTest.testPythonSideEffects60:6151->testPythonSideEffects:5408->lambda$55:5411 Function: C.g() should have side-effects. expected:<true> but was:<null>
  HybridizeFunctionRefactoringTest.testPythonSideEffects61:6180->testPythonSideEffects:5408->lambda$55:5411 Function: f() should have side-effects. expected:<true> but was:<false>
Errors: 
  HybridizeFunctionRefactoringTest.testClassInDifferentFile:6714 NullPointer Can...
  HybridizeFunctionRefactoringTest.testClassInDifferentFile4:6750 NullPointer Ca...
  HybridizeFunctionRefactoringTest.testModule6:7389 NullPointer Cannot invoke "j...

It seems like a problem in Ariadne.
@khatchad khatchad self-assigned this Oct 31, 2024
@khatchad khatchad added the bug Something isn't working label Oct 31, 2024
@khatchad khatchad added this to the Prototype implementation milestone Oct 31, 2024
@khatchad
Copy link
Member Author

Created https://github.com/ponder-lab/Hybridize-Functions-Refactoring/tree/374-build-failure-pertaining-to-multi-file-projects.

@khatchad
Copy link
Member Author

Seems related to #311.

@khatchad
Copy link
Member Author

Does it need a PYTHONPATH?

@khatchad
Copy link
Member Author

There seems to be some nondeterminism here. It works on laptop and on Travis CI but not on GitHub Actions nor my desktop. It might be useful to compare output from the working and not working cases.

@khatchad
Copy link
Member Author

Non-working case 59.log.

khatchad added a commit that referenced this issue Oct 31, 2024
@khatchad
Workaround build issue.
2e28c22 
#374.
@khatchad
Copy link
Member Author

khatchad commented Nov 7, 2024

Working case:
59_working.log

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@khatchad khatchad

Labels
bug Something isn't working
Projects
None yet
Milestone
Prototype implementation
Development

When branches are created from issues, their pull requests are automatically linked.

374-build-failure-pertaining-to-multi-file-projects ponder-lab/Hybridize-Functions-Refactoring
1 participant
@khatchad