New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The call() methods of custom layers are getting hybridized #328

Open

khatchad opened this issue Feb 17, 2024 · 1 comment

Labels

question

Milestone

Prototype impleme...

Member

khatchad commented Feb 17, 2024

That's because tensors are passe to them just like the call() methods of custom Models. Should we:

Only hybridize call() and __call()__ methods of Models.
Not hybridize call() and __call()__ methods of Layers.

Either of these would seem to be special cases.

The text was updated successfully, but these errors were encountered:

khatchad added the question label

khatchad added this to the Prototype implementation milestone

Member Author

khatchad commented Feb 17, 2024

Even though we are hybridizing call() of layers, it doesn't seem to have a big impact on performance. Maybe it's a little slower but not by much.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment