Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Function my_conv2d() missing from call graph #310

Open
khatchad opened this issue Jan 8, 2024 · 2 comments
Open

Function my_conv2d() missing from call graph #310

khatchad opened this issue Jan 8, 2024 · 2 comments
Labels
blocked bug Something isn't working experiments Found during experimentation/evaluation. question Further information is requested

Comments

@khatchad
Copy link
Member

khatchad commented Jan 8, 2024

Highly related to #307. This is what I am seeing in the CSVs:

subject function module relative path refactoring severity code message
samples my_conv2d trial03 tensorflow_weight_sharing/trial03.py OPTIMIZE_HYBRID_FUNCTION 3 3 Can't infer side-effects, most likely due to a call graph issue caused by a decorator or a missing function call.
samples my_conv2d trial03 tensorflow_weight_sharing/trial03.py OPTIMIZE_HYBRID_FUNCTION 3 10 Can't infer tensor parameters for this function.
samples my_conv2d trial03 tensorflow_weight_sharing/trial03.py OPTIMIZE_HYBRID_FUNCTION 3 11 Can't infer primitive parameters for this function.

But, my_conv2d() is called by indirectly by the model functions, I believe, but it isn't done through a callable. Instead, I believe it to be called by one of the other model functions here:

https://github.com/ponder-lab/samples/blob/39f7644391e664244b45c90868c804abad923eb3/tensorflow_weight_sharing/trial03.py#L98-L104

@khatchad khatchad self-assigned this Jan 8, 2024
@khatchad khatchad added experiments Found during experimentation/evaluation. bug Something isn't working question Further information is requested labels Jan 8, 2024
@khatchad khatchad changed the title Functio my_conv2d() missing from call graph Function my_conv2d() missing from call graph Jan 8, 2024
@khatchad khatchad removed their assignment Jan 8, 2024
@khatchad
Copy link
Member Author

khatchad commented Jan 8, 2024

It's called here: https://github.com/ponder-lab/samples/blob/39f7644391e664244b45c90868c804abad923eb3/tensorflow_weight_sharing/trial03.py#L99 by keras.engine.training.Model.build():

self.call(x, **kwargs)

@khatchad
Copy link
Member Author

khatchad commented Jan 8, 2024

Technically, this would be blocked by wala/ML#107.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked bug Something isn't working experiments Found during experimentation/evaluation. question Further information is requested
Projects
None yet
Development

No branches or pull requests

1 participant