Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential false positive on primitive parameter #308

Closed
khatchad opened this issue Jan 5, 2024 · 1 comment · Fixed by #314
Closed

Potential false positive on primitive parameter #308

khatchad opened this issue Jan 5, 2024 · 1 comment · Fixed by #314
Assignees
Labels
bug Something isn't working experiments Found during experimentation/evaluation.

Comments

@khatchad
Copy link
Member

khatchad commented Jan 5, 2024

subject function module relative path parameters tensor parameter primitive parameter hybrid side-effects recursive refactoring passing precondition status
samples MyConvolution2D.call tensorflow_keras_custom_layer tensorflow_keras_custom_layer/tensorflow_keras_custom_layer.py 2 TRUE TRUE FALSE FALSE FALSE CONVERT_EAGER_FUNCTION_TO_HYBRID   3

I don't see a primitive parameter here:

https://github.com/ponder-lab/samples/blob/39f7644391e664244b45c90868c804abad923eb3/tensorflow_keras_custom_layer/tensorflow_keras_custom_layer.py#L39-L57

I only see input_node here, but that should be a tensor:

https://github.com/ponder-lab/samples/blob/39f7644391e664244b45c90868c804abad923eb3/tensorflow_keras_custom_layer/tensorflow_keras_custom_layer.py#L60-L61

@khatchad khatchad added bug Something isn't working experiments Found during experimentation/evaluation. labels Jan 5, 2024
@khatchad khatchad self-assigned this Jan 5, 2024
@khatchad
Copy link
Member Author

!ENTRY edu.cuny.hunter.hybridize.core 1 0 2024-01-10 11:38:22.036
!MESSAGE Found constant value: 3 for parameter of: MyConvolution2D.call().

khatchad added a commit that referenced this issue Jan 10, 2024
Fix #308.
Account for self as being a potential parameter.
@khatchad khatchad linked a pull request Jan 10, 2024 that will close this issue
khatchad added a commit that referenced this issue Jan 10, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
…on-primitive-parameter

Fix #308
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working experiments Found during experimentation/evaluation.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant