From 2f49d0cdecfea780b235a3bc026c6f7aa3923a8d Mon Sep 17 00:00:00 2001 From: Raffi Khatchadourian Date: Thu, 9 Nov 2023 22:12:53 -0500 Subject: [PATCH] Don't stop checking if side-effects can't be determined. --- .../refactorings/HybridizeFunctionRefactoringProcessor.java | 4 ---- 1 file changed, 4 deletions(-) diff --git a/edu.cuny.hunter.hybridize.core/src/edu/cuny/hunter/hybridize/core/refactorings/HybridizeFunctionRefactoringProcessor.java b/edu.cuny.hunter.hybridize.core/src/edu/cuny/hunter/hybridize/core/refactorings/HybridizeFunctionRefactoringProcessor.java index 5b8046e18..2be327b47 100644 --- a/edu.cuny.hunter.hybridize.core/src/edu/cuny/hunter/hybridize/core/refactorings/HybridizeFunctionRefactoringProcessor.java +++ b/edu.cuny.hunter.hybridize.core/src/edu/cuny/hunter/hybridize/core/refactorings/HybridizeFunctionRefactoringProcessor.java @@ -247,10 +247,6 @@ private RefactoringStatus checkFunctions(IProgressMonitor monitor) throws Operat LOG.warn("Unable to infer side-effects of: " + func + ".", e); func.addFailure(PreconditionFailure.UNDETERMINABLE_SIDE_EFFECTS, "Can't infer side-effects, most likely due to a call graph issue caused by a decorator or a missing function call."); - // next function. FIXME: Why not continue? - status.merge(func.getStatus()); - subMonitor.worked(1); - return; } // check the function preconditions.