SBP M1 Review #57
Closed
SBP M1 Review #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on-light-client into dami/execution-payload-timestamp � Conflicts: � README.md
…v0.9.38 polkadot v0.9.38
…/polytope-labs/sync-committee-rs into dami/execution-payload-timestamp � Conflicts: � primitives/Cargo.toml � prover/Cargo.toml � prover/src/test.rs � verifier/Cargo.toml
Co-authored-by: David Salami <[email protected]>
Co-authored-by: Seun Lanlege <[email protected]>
Co-authored-by: Seun Lanlege <[email protected]>
Co-authored-by: David Salami <[email protected]>
seunlanlege
reviewed
Nov 28, 2023
seunlanlege
reviewed
Nov 28, 2023
seunlanlege
reviewed
Nov 28, 2023
seunlanlege
reviewed
Nov 28, 2023
seunlanlege
force-pushed
the
main
branch
2 times, most recently
from
adf42ad to
d5047fc
Compare
seunlanlege
added a commit
that referenced
this pull request
May 6, 2024
* some refactorings * Respect module filter * make delivery endpoints optional * use debian bookworm slim * clean up some interfaces * if filter is empty, allow all modules * fix log * accumulate fees for all chains * some more stuff * intialize latest heights for L2s * add execution layer state commitment * verified that accumulate & withdraw works
seunlanlege
added a commit
that referenced
this pull request
May 8, 2024
* don't use statemachine id' * don't hardcode keys
seunlanlege
pushed a commit
that referenced
this pull request
May 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The feedback for the SBP M1 review can be found under the code comment :
In general the project looks strong and just minor tweaks were pointed out.
Please dismiss any formatting suggested change.