Skip to content
This repository has been archived by the owner on Jan 21, 2024. It is now read-only.

Implement Material You Icon theme on Android 12 #199

Open
3 of 5 tasks
commit-ezza opened this issue May 21, 2022 · 6 comments
Open
3 of 5 tasks

Implement Material You Icon theme on Android 12 #199

commit-ezza opened this issue May 21, 2022 · 6 comments
Labels
enhancement New feature or request

Comments

@commit-ezza
Copy link

commit-ezza commented May 21, 2022

Checklist

  • I made sure that there are no existing issues - open or closed - which I could contribute my information to.
  • I'm aware that this is a request for NewPipe itself and that requests for adding a new service need to be made at NewPipeExtractor.
  • I have taken the time to fill in all the required details. I understand that the feature request will be dismissed otherwise.
  • This issue contains only one feature request.
  • I have read and understood the contribution guidelines.

Feature description

Implementing the material you icon theme on android 12.

Why do you want this feature?

Not significant, but nice to have.

Why ist the feature relevant to this fork?

Regular NewPipe already implement it, but this one hasn't yet

Additional information

No response

@commit-ezza commit-ezza added the enhancement New feature or request label May 21, 2022
@Atemu
Copy link

Atemu commented May 21, 2022

Regular NewPipe already implement it, but this one hasn't yet

Where?

@commit-ezza
Copy link
Author

commit-ezza commented May 22, 2022

Already tried it on my Pure Android 12, regular newpipe does work indeed, but this version doesn't.
Screenshot_20220522-073819_Pixel Launcher

@ymstnt
Copy link

ymstnt commented Jun 17, 2022

Looks like a duplicate of #182

However, may I ask what ROM are you using? As far as I know, the required API for themed icons was only added in Android 13 betas, and in Android 12, it is up to the ROM developer to add custom icons to apps.

@jakweg
Copy link

jakweg commented Sep 29, 2022

ArrowOS 12 also supports new icons - they look gorgeous, but NewPipe SB is sticking out :(

@w9925
Copy link

w9925 commented Oct 16, 2022

Any update on this? Would be nice if someone can add this

@killerrook
Copy link

There has been a fix related to material you icons in latest release v0.24.1 check if your issue is resolved?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

6 participants