Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The cache folder size returned by react-native-fs is always wrong #104

Open
umbopepato opened this issue Mar 10, 2023 · 1 comment
Open
Assignees
Labels
🐞 bug Something isn't working

Comments

@umbopepato
Copy link
Member

Ref itinance/react-native-fs#884 (comment).

@umbopepato umbopepato added the 🐞 bug Something isn't working label Mar 10, 2023
@umbopepato umbopepato self-assigned this Mar 10, 2023
@lpezzolla lpezzolla added this to the v1.0 Public Beta milestone Mar 13, 2023
@lpezzolla lpezzolla removed this from the v1.0 Public Beta milestone Mar 20, 2023
@lpezzolla lpezzolla added this to the v1.3.3 milestone Aug 10, 2023
@lpezzolla lpezzolla assigned lpezzolla and unassigned umbopepato Aug 10, 2023
@lpezzolla lpezzolla moved this from Todo to In Progress in PoliTO Students App Aug 10, 2023
@lpezzolla
Copy link
Member

The size returned by the library should be divided by 1000 (it is actually documented as bytes, but used as kb in our code).

On Android, the size differs slightly from the sum of contained files as also the size of the folder is considered, but it does not bother me.

On iOS it seems to return the size of the inode (which is clearly useless) - increased by 32 bytes for each downloaded file into the folder.

The size difference between the single course and the settings screen is caused by the mixed usage of the root folder (it is also used to cache network responses and other RN stuff) - we might want to introduce a containing folder for all course files.

@lpezzolla lpezzolla moved this from In Progress to Todo in PoliTO Students App Aug 29, 2023
@lpezzolla lpezzolla modified the milestones: v1.4.0, v1.5.0 Sep 5, 2023
@lpezzolla lpezzolla removed this from the v1.5.0 milestone Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working
Projects
Status: Todo
Development

No branches or pull requests

2 participants