Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrectly named formes in spriteset #2

Open
NoelDavies opened this issue Aug 8, 2023 · 0 comments
Open

Fix incorrectly named formes in spriteset #2

NoelDavies opened this issue Aug 8, 2023 · 0 comments
Assignees

Comments

@NoelDavies
Copy link
Contributor

NoelDavies commented Aug 8, 2023

Initially issue detected in ./assets/pokemon/s-m

Expected:
Alolan forms should match with formes, defined in defaultSettings.js

// regional forms
    'rattata': { 'alola': 'rattata-alola' },
    'raticate': { 'alola': 'raticate-alola' },
    'raichu': { 'alola': 'raichu-alola' },
    'sandshrew': { 'alola': 'sandshrew-alola' },
    'sandslash': { 'alola': 'sandslash-alola' },
    'vulpix': { 'alola': 'vulpix-alola' },
    'ninetales': { 'alola': 'ninetales-alola' },
    'diglett': { 'alola': 'diglett-alola' },
    'dugtrio': { 'alola': 'dugtrio-alola' },
    'persian': { 'alola': 'persian-alola' },
    'geodude': { 'alola': 'geodude-alola' },
    'graveler': { 'alola': 'graveler-alola' },
    'golem': { 'alola': 'golem-alola' },
    'grimer': { 'alola': 'grimer-alola' },
    'exeggutor': { 'alola': 'exeggutor-alola' },
    'marowak': { 'alola': 'marowak-alola' },

Actual:
Alolan forms had the suffix of -a instead of -alola.

Next Steps:

  • Check if issue is in prod
  • Rename files in s-m
  • Search for any other occurrences of this issue
@NoelDavies NoelDavies self-assigned this Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant