Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot Start Up Themes? #5

Open
Minepatcher opened this issue Oct 28, 2024 · 2 comments
Open

Cannot Start Up Themes? #5

Minepatcher opened this issue Oct 28, 2024 · 2 comments

Comments

@Minepatcher
Copy link

Hello!
I am trying to simply look at my PokeLink Session to create my own templates and such.

I tried what the README states and tried to view just the basic card to start. But it looks like there is a null error happening during the process. I tested a couple other themes and the error is consistent through all themes I tried. It seems this null error is happening on a param called 'neo'? This is with using the MASTER branch and looking at the other branches the client.js files are all different.

Please let me know if I am doing something wrong, or if I need to add something to my computer as it didn't seem like I needed to add Socket.io or anything to my computer from the README.
Thanks!

Issue_1
Issue_2

@Minepatcher
Copy link
Author

It looks like replacing the current GitHub client.js file with the client.js file from PokeLink fixed the issue, so I'm guessing the issue is with that file specifically.

@Minepatcher
Copy link
Author

Officially fixed by changing line 109 and 117 to:
if (params.get("neo")?.toLowerCase() === "true") {
param neo doesn't normally exist to be passed in therefore is null at this point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant