Convert SSOP-10_3.9x4.9mm_P1.00mm to generator, and add SOP-10_3.9x4.9mm_P1mm and NSOP-16_3.9x9.9mm_P1.27mm #645
Conversation
…9mm_P1.00mm and NSOP-16_3.9x9.9mm_P1.27mm see KiCad/kicad-footprints#2432 for explanation
|
Code Climate has analyzed commit 67c6c67 and detected 0 issues on this pull request. View more on Code Climate. |
|
I also found that I had to edit the other entries in soic.yaml to use |
| @@ -432,7 +432,7 @@ SOIC-8_7.5x5.85mm_P1.27mm: | |||
|
|
|||
| SOIC-14_3.9x8.7mm_P1.27mm: | |||
| #round to two significant digits to comply with old name | |||
| custom_name_format: SOIC-{pincount:d}_{size_x:.2g}x{size_y:.2g}mm_P{pitch:g}mm | |||
| custom_name_format: SOIC-{pincount:s}_{size_x:.2g}x{size_y:.2g}mm_P{pitch:g}mm | |||
There was a problem hiding this comment.
Why did you change all of those?
edit: I see that you commented on that. My first guess is that this is an unintended changed in the generator.
There was a problem hiding this comment.
Yeah, I can undo this change if you want, but then the script crashes on generating soic.yaml.
There was a problem hiding this comment.
FYI: We are discussing this issue in #649
scripts/Packages/Package_Gullwing__QFP_SOIC_SO/size_definitions/nsop.yaml
Outdated
Show resolved
Hide resolved
scripts/Packages/Package_Gullwing__QFP_SOIC_SO/size_definitions/nsop.yaml
Outdated
Show resolved
Hide resolved
scripts/Packages/Package_Gullwing__QFP_SOIC_SO/size_definitions/nsop.yaml
Outdated
Show resolved
Hide resolved
| minimum: 3.80 | ||
| maximum: 4.00 | ||
| body_size_y: | ||
| minimum: 4.80 | ||
| maximum: 5.00 |
There was a problem hiding this comment.
Where did you get the min-max values from?
There was a problem hiding this comment.
Sorry, I didn't realize you were able to just write exact values! These don't have tolerances, so I changed them.
scripts/Packages/Package_Gullwing__QFP_SOIC_SO/size_definitions/sop.yaml
Outdated
Show resolved
Hide resolved
scripts/Packages/Package_Gullwing__QFP_SOIC_SO/size_definitions/ssop.yaml
Outdated
Show resolved
Hide resolved
scripts/Packages/Package_Gullwing__QFP_SOIC_SO/size_definitions/ssop.yaml
Outdated
Show resolved
Hide resolved
This PR converts the existing SSOP-10_3.9x4.9mm_P1.00mm footprint to be automatically generated. (the name is overridden, so that it stays as P1.00mm rather than P1mm for compatibility).
This also adds some duplicate symbols:
(See KiCad/kicad-footprints#2432 for explanation/justification)