-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KiCad Plugin and Content Manager addition #28
Comments
The two themes I added to this repo (kicad-classic and kicad-default) should not be included in the PCM as they are built-in to KiCad. |
I am happy for the Eagle-style theme to be included.
Please use ***@***.*** as contact info, and Rachel Mant as the
name.
Rachel.
…On 30/10/2021 17:35, Thomas Pointhuber wrote:
Dear color theme contributors @poeschlr <https://github.com/poeschlr>
@esden <https://github.com/esden> @DX-MON <https://github.com/DX-MON>
@craftyjon <https://github.com/craftyjon> @wykys
<https://github.com/wykys>
I was asked to add those color schemes into the Plugin and Content
Manager repository. Thus I would like to ask if you are OK with adding
you as author (please give me a name, and as contact info I will
simply add your github user if you like). As license, I set this repo
to CC0-1.0, but I can set a different license on your theme if you like.
Either you create a PR with the given metadata.json file, or I will
create one if you are ok with it. The file looks like this and is
added to the color-scheme-directory. The directory further has to
include the color-scheme in json format which I can then bundle into a
package.
{
"$schema":"https://gitlab.com/qu1ck/kicad/-/raw/pcm/kicad/pcm/schemas/pcm.v1.schema.json#",
"name":"solarized-light theme",
"description":"solarized-light color theme",
"description_full":"solarized-light color theme",
"identifier":"theme-solarized-light",
"type":"colortheme",
"author": {
"name":"Thomas Pointhuber",
"contact": {
"web":"https://github.com/pointhi/kicad-color-schemes/"
}
},
"maintainer": {
"name":"Thomas Pointhuber",
"contact": {
"web":"https://github.com/pointhi/kicad-color-schemes/"
}
},
"license":"CC0-1.0",
"resources": {
"Github":"https://github.com/pointhi/kicad-color-schemes"
},
"versions": [{
"version":"1.0",
"status":"stable",
"kicad_version":"5.99"
}]
}
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#28>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAFIXRFY3X4O2JYXA5GFCHLUJQUFTANCNFSM5HBH7ENA>.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
I am also pleased with this initiative. Please enter a name Jan Vykydal. |
The nord theme that I submitted is actually desigend by @jordiorlando I only did some conversion to add it here. I think the approval and credit should go to him. If it was up to me I would definitely be fine with getting the theme added. :) |
That's looking awesome!
We have a couple of layer fixes for 8-layer stuff in the Eagle inspired
theme due which we'll try and land before this lands, but that should be
all that needs doing for that theme.
Rachel.
…On 30/10/2021 22:10, Thomas Pointhuber wrote:
This is a sneak peak how it looks right now:
PCM example
<https://user-images.githubusercontent.com/1652144/139558441-f0e15a5b-4268-4b48-bf94-dc5ffb22f6d6.png>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#28 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAFIXRGAWFH7VZRI62DKSF3UJRUMXANCNFSM5HBH7ENA>.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
@DX-MON maybe we can add a light and a dark Eagle theme. I suppose only the background color is different? |
As KiCad introduced various new color tags over time, it would be nice if all themes we include in the package manager have all colors assigned. I did this for solarized in this commit: c6a545a |
This looks great! And thanks for the credit @esden 😄 |
I have written a message to the person who provided the monokai theme on the forum. |
Personally, I'd be happy for the monokai theme to be available in a theme selector. My name's Ash Watson. I am not the creator of the colour set itself though, I just posted a modified config file text back in 2018. So really it shouldn't be up to me. |
Sorry for the late response. I kind of missed this (was somehow lost in my inbox) I am ok with anyone using my work however they want. |
@pointhi is there a way for you to change @0xdec to @jordiorlando in the plug-in manager? Or perhaps I should open an issue in GitLab? |
Thanks for getting most themes into the addon manager already! Any reason for Behave-dark to be missing from the manager though? |
Dear color theme contributors @poeschlr @esden @DX-MON @craftyjon @wykys
I was asked to add those color schemes into the Plugin and Content Manager repository. Thus I would like to ask if you are OK with adding you as author (please give me a name, and as contact info I will simply add your github user if you like). As license, I set this repo to CC0-1.0, but I can set a different license on your theme if you like.
Either you create a PR with the given metadata.json file, or I will create one if you are ok with it. The file looks like this and is added to the color-scheme-directory. The directory further has to include the color-scheme in json format which I can then bundle into a package.
The text was updated successfully, but these errors were encountered: