-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Performance optimizations #4
Comments
We should also add some benchmarks, similar to the ones in threshold_crypto, but maybe more deterministic ones. |
Perf is utterly useless on my system ― it records almost all of the time being spent on GMP internals with no detailed information. I suspect that parts of GMP are missing frame unwind information. |
I should probably report this as a bug in Fedora’s GMP. |
Some good news is that all but a few percent of the time is spent in GMP, and very little is spent doing memory allocation. So the performance is probably close to optimal. |
It might be possible to optimize even more by switching to low-level GMP calls. The guts of GMP are written in assembler, but the convenience functions could be ported to Rust and then inlined. |
Sounds good! Yes, I guess perf isn't that useful for now then. |
There are probably optimizations to be made, both in terms of micro-optimization, and in terms of the algorithms used.
The text was updated successfully, but these errors were encountered: