Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(Fix) Deny repeatedly adding removed mining key #102

Open
varasev opened this issue May 25, 2018 · 3 comments
Open

(Fix) Deny repeatedly adding removed mining key #102

varasev opened this issue May 25, 2018 · 3 comments
Labels
done Done but not yet used in a network good first issue

Comments

@varasev
Copy link
Contributor

varasev commented May 25, 2018

The current version of VotingToChangeKeys contract allows adding new miningKey that was removed in the past. The suggestion is to prohibit the addition of such miningKey.
@maxaleks
Copy link
Contributor

Hi @varasev
How can I check that some miningKey was removed?

@varasev
Copy link
Contributor Author

varasev commented Jun 13, 2019

Hey @maxaleks
The contracts don't have such a boolean flag which would let us know that a specified mining key has been removed. This issue assumes creating some logic for that.

@maxaleks maxaleks mentioned this issue Jun 17, 2019
Merged
@varasev
Copy link
Contributor Author

varasev commented Jun 21, 2019

Done in #208.

@varasev varasev added the done Done but not yet used in a network label Jun 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
done Done but not yet used in a network good first issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@igorbarinov @maxaleks @varasev