Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More tests: DynamicHoneyBadger #402

Open
afck opened this issue Apr 3, 2019 · 0 comments
Open

More tests: DynamicHoneyBadger #402

afck opened this issue Apr 3, 2019 · 0 comments

Comments

@afck
Copy link
Collaborator

afck commented Apr 3, 2019

The DynamicHoneyBadger tests currently don't include adversaries that send messages. They should be extended in the same way as the HoneyBadger tests: #401
Or should they? What's the best way to avoid duplicating the same kind of tests for all three *HoneyBadgers? At least the adversaries' strategies here should probably focus on validator set changes (voting, key generation, etc.).

Let's also rename the file to dynamic_honey_badger.rs.

Apart from #386, are there any additional patterns of validator set changes that we should add?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants