Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for MS Graph Search endpoint #1301

Open
1 task done
hazzinator1 opened this issue Oct 20, 2023 · 1 comment
Open
1 task done

Support for MS Graph Search endpoint #1301

hazzinator1 opened this issue Oct 20, 2023 · 1 comment
Labels
area: model 📐 Related to the core SDK models help wanted Extra attention is needed

Comments

@hazzinator1
Copy link

Category

  • Feature request

Describe the feature

We have recently swapped over from PnPJS in the UI to making our Graph/SharePoint calls with PnPCore in our API. I was shocked to find that PnPCore doesn't currently support the Graph Search endpoint (https://graph.microsoft.com/v1.0/search/query), and instead uses the SharePoint API endpoint (_api/search/postquery). We are making heavy use of the Graph Search endpoint in our app, and cannot verify whether we are going to be running into problems by using the SharePoint search instead. They seem roughly similar, but I would still be a lot more comfortable if I knew PnPCore could support Graph searching natively.

Describe the solution you'd like

Happy to leave it up to the devs to determine this, but a strongly typed way of accessing the Graph Search endpoint would be required. Some inspiration could be taken from how GraphServiceClient does it within the Microsoft.Graph Nuget package.

Additional context

I have gone the route of leveraging the GraphServiceClient.Search.Query from Microsoft Graph for now.

@jansenbe
Copy link
Contributor

@hazzinator1 : this is on the todo list, but given my busy schedule I did not get to it yet. While waiting for native support you can always opt to directly call the needed Graph endpoint yourselves, this is quite easy via our option to call a custom API call as explained here: https://pnp.github.io/pnpcore/using-the-sdk/basics-customapirequests.html#making-a-custom-microsoft-graph-request

@jansenbe jansenbe added the question Further information is requested label Oct 21, 2023
@jansenbe jansenbe added help wanted Extra attention is needed area: model 📐 Related to the core SDK models and removed question Further information is requested labels Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: model 📐 Related to the core SDK models help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants